Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make /coverage and /docs work in new CI #36356

Closed
phlax opened this issue Sep 26, 2024 · 4 comments · Fixed by #36410
Closed

Make /coverage and /docs work in new CI #36356

phlax opened this issue Sep 26, 2024 · 4 comments · Fixed by #36410
Assignees
Labels
area/coverage area/docs bug enhancement Feature requests. Not bugs or questions.

Comments

@phlax
Copy link
Member

phlax commented Sep 26, 2024

one of the things that wasnt included in first iteration of github migration is the publishing of docs and coverage

this is necessary for /docs and /coverage commands to work on PRs

readding should not be so hard - it requires some creds and setup for the gcs_upload script

@phlax phlax added enhancement Feature requests. Not bugs or questions. triage Issue requires triage bug area/docs area/coverage and removed triage Issue requires triage labels Sep 26, 2024
@phlax phlax self-assigned this Sep 26, 2024
@phlax
Copy link
Member Author

phlax commented Sep 26, 2024

cc @ravenblackx

@ravenblackx
Copy link
Contributor

ravenblackx commented Sep 26, 2024

As a local workaround in the meantime (that takes ages because it rebuilds everything in coverage mode):

bazel coverage [the set of test targets you expect to cover the thing you're checking]
(find bazel-out/k8-fastbuild/testlogs/ -name "coverage.dat" | xargs genhtml -o ~/coverage && cd ~/coverage && python3 -m http.server)

@ravenblackx
Copy link
Contributor

Also probably worth noting here that the CI coverage failure is currently difficult to see the important details; doing a log search for lower than limit seems to be the only way I can get the useful info to appear, which is pretty unhelpful if you don't already know what to look for.

@phlax
Copy link
Member Author

phlax commented Sep 26, 2024

that is actually really easy - ill raise a PR now ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/coverage area/docs bug enhancement Feature requests. Not bugs or questions.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants