Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golang filter: support full-duplex #33377

Merged
merged 44 commits into from
Jun 11, 2024
Merged

Conversation

doujiang24
Copy link
Member

fix: #32033

status: only some prepare work in the C++ side.

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: doujiang24 <[email protected]>
Signed-off-by: doujiang24 <[email protected]>
Signed-off-by: doujiang24 <[email protected]>
Signed-off-by: doujiang24 <[email protected]>
Signed-off-by: doujiang24 <[email protected]>
Signed-off-by: doujiang24 <[email protected]>
Signed-off-by: doujiang24 <[email protected]>
@doujiang24 doujiang24 marked this pull request as draft April 7, 2024 12:46
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added stale stalebot believes this issue/PR has not been touched recently and removed stale stalebot believes this issue/PR has not been touched recently labels May 17, 2024
@doujiang24
Copy link
Member Author

/retest

Signed-off-by: doujiang24 <[email protected]>
Signed-off-by: doujiang24 <[email protected]>
Signed-off-by: doujiang24 <[email protected]>
Signed-off-by: doujiang24 <[email protected]>
Signed-off-by: doujiang24 <[email protected]>
Signed-off-by: doujiang24 <[email protected]>
Signed-off-by: doujiang24 <[email protected]>
@doujiang24 doujiang24 changed the title wip: golang filter: support full-duplex golang filter: support full-duplex Jun 7, 2024
@doujiang24 doujiang24 marked this pull request as ready for review June 7, 2024 08:31
contrib/golang/common/go/api/api.h Outdated Show resolved Hide resolved
contrib/golang/common/go/api/capi.go Outdated Show resolved Hide resolved
contrib/golang/filters/http/source/processor_state.h Outdated Show resolved Hide resolved
contrib/golang/filters/http/source/golang_filter.cc Outdated Show resolved Hide resolved
Signed-off-by: doujiang24 <[email protected]>
@doujiang24
Copy link
Member Author

@spacewander Thanks, all addressed.

@alyssawilk alyssawilk self-assigned this Jun 10, 2024
@alyssawilk
Copy link
Contributor

I'll let @spacewander do review and will merge once it's been LGTM'd

Signed-off-by: doujiang24 <[email protected]>
Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer stamp

@alyssawilk alyssawilk enabled auto-merge (squash) June 11, 2024 12:43
@alyssawilk
Copy link
Contributor

/retest
will auto-merge once CI is happy

@alyssawilk
Copy link
Contributor

hmmmm, CI looks stalled - doing a main merge may unstick it

@alyssawilk alyssawilk merged commit 34fa1fc into envoyproxy:main Jun 11, 2024
49 of 50 checks passed
@doujiang24 doujiang24 deleted the golang-duplex branch June 12, 2024 01:05
spacewander pushed a commit to mosn/envoy that referenced this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic when use golang filter decode http2 connect tunnel data
3 participants