Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bidirectional streaming grpc panic #34536

Closed
zgqqiang opened this issue Jun 5, 2024 · 6 comments
Closed

bidirectional streaming grpc panic #34536

zgqqiang opened this issue Jun 5, 2024 · 6 comments
Labels
area/golang bug stale stalebot believes this issue/PR has not been touched recently

Comments

@zgqqiang
Copy link

zgqqiang commented Jun 5, 2024

I used the Golang interceptor to modify the data in the GRPC dynamic modification @doujiang24

Service RequestStream{
//Build a streamRequest
Rpc requestStream (Payload) returns (stream Payload){
}
}This can
Service BiRequestStream{
//Sends a commonRequest
Rpc requestBiStream (stream Payload) returns (stream Payload){
}
}This bidirectional flow GRPC will report an error

type.googleapis.com/envoy.extensions.filters.http.golang.v3alpha.Config

Envoy version v1.30.1 found panic
The error is as follows:

[2024-06-05 02:22:48.188] [60] [error] [golang] [contrib/golang/common/log/cgo. cc: 24] http: panic serving: not processing Go
Goroutine 35 [running, locked to thread]:
Github. com/envoyproxy/envoy/contrib/golang/filters/http/source/go/pkg/http. (* htpRequest) RecoverPanic (0xc000198600)
/Data/go/pkg/mod/github. com/envoyproxy/ [email protected] /Contrib/golang/filters/http/source/go/pkg/http/filters. go: 134+0x65
Pan ({0x7eff073ed0a0?, 0xc000099ae0?})
/Usr/local/go/src/runtime/panic. go: 770+0x132
Github. com/envoyproxy/envoy/contrib/golang/filters/http/source/go/pkg/http. handleCApiStatus (...)
/Data/go/pkg/mod/github. com/envoyproxy/ [email protected] /Contrib/golang/filters/http/source/go/pkg/http/capi_impl. go: 81
Github. com/envoyproxy/envoy/contrib/golang/filters/http/source/go/pkg/http. (* htpCApiImpl) HttpGetBuffer (0x0?, 0x52bff31ec80, 0x52bff328480, 0x81)
/Data/go/pkg/mod/github. com/envoyproxy/ [email protected] /Contrib/golang/filters/http/source/go/pkg/http/capi_impl. go: 214+0xc5
Github. com/envoyproxy/envoy/contrib/golang/filters/http/source/go/pkg/http. (* htpBuffer) Bytes (0xc00028c570)
/Data/go/pkg/mod/github. com/envoyproxy/ [email protected] /Contrib/golang/filters/http/source/go/pkg/http/type. go: 387+0x3d
Main. (* filter) DecodeData (0x7eff07416f20?, {0x7eff074b9df8, 0xc00028c570}, 0x0)
/Data/zgq/mosn/invoice/filter. go: 78+0xe2
Github. com/envoyproxy/envoy/contrib/golang/filters/http/source/go/pkg/http. envoyGoFilterOnHttpData (0x52bff31ec80, 0x0, 0x52bff328480, 0x81)
/Data/go/pkg/mod/github. com/envoyproxy/ [email protected] /Contrib/golang/filters/http/source/go/pkg/http/ship. go: 229+0x150

The community has also found the same case, but it has not been merged into the version. Is there a plan
#32033
#33377

@zgqqiang zgqqiang added bug triage Issue requires triage labels Jun 5, 2024
@adisuissa adisuissa added area/golang and removed triage Issue requires triage labels Jun 5, 2024
@adisuissa
Copy link
Contributor

cc @doujiang24 @wangfakang

@doujiang24
Copy link
Member

@zgqqiang
#33377 is working in progess, and it's very close to ready, sorry to the late.

@doujiang24
Copy link
Member

Hello @zgqqiang , #33377 is merged, would you like to have a try? thanks.

@zgqqiang
Copy link
Author

I have retested based on the latest submission and the functionality is normal. Thank you @doujiang24

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jul 17, 2024
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/golang bug stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

3 participants