Skip to content

examples/grpc: remove useless go.mod #31318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phlax merged 3 commits into from
Dec 13, 2023
Merged

examples/grpc: remove useless go.mod #31318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a87fe9
examples/grpc: remove useless go.mod
doujiang24 Dec 13, 2023
7016a22
remove dependabot
doujiang24 Dec 13, 2023
ad95322
remove in Dockerfile.
doujiang24 Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,12 +281,6 @@ updates:
interval: daily
time: "06:00"

- package-ecosystem: "gomod"
directory: "/examples/grpc-bridge/server/kv"
schedule:
interval: daily
time: "06:00"

- package-ecosystem: "gomod"
directory: "/examples/golang-http/simple"
schedule:
Expand Down
6 changes: 2 additions & 4 deletions examples/grpc-bridge/server/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
module github.com/envoyproxy/envoy
module github.com/envoyproxy/envoy/examples/grpc-bridge/server

go 1.13

require (
github.com/envoyproxy/envoy/examples/grpc-bridge/server/kv v0.0.0-00010101000000-000000000000
github.com/golang/protobuf v1.5.2
golang.org/x/net v0.8.0
google.golang.org/genproto v0.0.0-20230306155012-7f2fa6fef1f4 // indirect
google.golang.org/grpc v1.53.0
)

replace github.com/envoyproxy/envoy/examples/grpc-bridge/server/kv => ./kv
8 changes: 8 additions & 0 deletions examples/grpc-bridge/server/kv/empty.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
// make the kv module is not empty, make go mod tidy happy.
// a kv.pb.go file will be generated by protoc, while running the example.
// also, introduce the empty.go file to import the protobuf package,
// which will be imported from the generated kv.pb.go file.

package kv

import _ "github.com/golang/protobuf/proto"
3 changes: 0 additions & 3 deletions examples/grpc-bridge/server/kv/go.mod
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion examples/shared/golang/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ WORKDIR /build
# Resolve and build Go dependencies as Docker cache
COPY go.mod /build/go.mod
COPY go.sum /build/go.sum
COPY kv/go.mod /build/kv/go.mod
ENV GO111MODULE=on
RUN go mod download
COPY service.go /build/main.go
Expand Down