examples/grpc: remove useless go.mod#31318
Merged
phlax merged 3 commits intoenvoyproxy:mainfrom Dec 13, 2023
Merged
Conversation
also introduce the empty.go file to import the protobuf package, which will be imported from the generated kv.pb.go file. Signed-off-by: doujiang24 <doujiang24@gmail.com>
doujiang24
force-pushed
the
fix-example-grpc
branch
from
b359b30 to
6a87fe9
Compare
Signed-off-by: doujiang24 <doujiang24@gmail.com>
Signed-off-by: doujiang24 <doujiang24@gmail.com>
Member
Author
|
/retest |
phlax
approved these changes
Dec 13, 2023
Member
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
lgtm, thanks @doujiang24 for resolving this
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Dec 14, 2023
also introduce the empty.go file to import the protobuf package, which will be imported from the generated kv.pb.go file. Signed-off-by: doujiang24 <doujiang24@gmail.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
that referenced
this pull request
Dec 14, 2023
also introduce the empty.go file to import the protobuf package, which will be imported from the generated kv.pb.go file. Signed-off-by: doujiang24 <doujiang24@gmail.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Dec 15, 2023
also introduce the empty.go file to import the protobuf package, which will be imported from the generated kv.pb.go file. Signed-off-by: doujiang24 <doujiang24@gmail.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
that referenced
this pull request
Dec 15, 2023
also introduce the empty.go file to import the protobuf package, which will be imported from the generated kv.pb.go file. Signed-off-by: doujiang24 <doujiang24@gmail.com> Signed-off-by: Ryan Northey <ryan@synca.io>
SeanKilleen
pushed a commit
to SeanKilleen/envoy
that referenced
this pull request
Apr 3, 2024
also introduce the empty.go file to import the protobuf package, which will be imported from the generated kv.pb.go file. Signed-off-by: doujiang24 <doujiang24@gmail.com> Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Sean Killeen <SeanKilleen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
try to make dependabot-updater happy.
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]