Skip to content

Implementaion of ext_proc filter disable immediate response#28989

Merged
htuch merged 3 commits intoenvoyproxy:mainfrom
yanjunxiang-google:disable_ir_implement
Aug 16, 2023
Merged

Implementaion of ext_proc filter disable immediate response#28989
htuch merged 3 commits intoenvoyproxy:mainfrom
yanjunxiang-google:disable_ir_implement

Conversation

@yanjunxiang-google
Copy link
Copy Markdown
Contributor

@yanjunxiang-google yanjunxiang-google commented Aug 11, 2023

This is implementation to address issue: #28698.

It's a follow up PR of #28907

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

…server.

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @mattklein123
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #28989 was opened by yanjunxiang-google.

see: more, trace.

@yanjunxiang-google yanjunxiang-google changed the title Implementaion of ext_proc filter disable immediate response from the … Implementaion of ext_proc filter disable immediate response Aug 11, 2023
@yanjunxiang-google
Copy link
Copy Markdown
Contributor Author

/assign @tyxia @htuch @rshriram

Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo two nits.

Copy link
Copy Markdown
Member

@tyxia tyxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo nits

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
@yanjunxiang-google
Copy link
Copy Markdown
Contributor Author

@envoyproxy/api-shepherds The API change is just removed a [:not-implemented-hide] comment. PTAL

@htuch htuch merged commit 00309b2 into envoyproxy:main Aug 16, 2023
phlax added a commit to phlax/envoy that referenced this pull request Aug 17, 2023
…nvoyproxy#28989)"

This reverts commit 00309b2.

Signed-off-by: Ryan Northey <ryan@synca.io>
ashishb-90 pushed a commit to solo-io/envoy-fork that referenced this pull request Nov 30, 2023
…xy#28989)

This is implementation to address issue: envoyproxy#28698.

It's a follow up PR of envoyproxy#28907

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
ashishb-90 pushed a commit to solo-io/envoy-fork that referenced this pull request Nov 30, 2023
…xy#28989)

This is implementation to address issue: envoyproxy#28698.

It's a follow up PR of envoyproxy#28907

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants