Adding API to disable ext_proc immedate response#28907
Merged
htuch merged 2 commits intoenvoyproxy:mainfrom Aug 10, 2023
Merged
Adding API to disable ext_proc immedate response#28907htuch merged 2 commits intoenvoyproxy:mainfrom
htuch merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Contributor
Author
tyxia
approved these changes
Aug 9, 2023
Member
tyxia
left a comment
tyxia
left a comment
There was a problem hiding this comment.
LGTM, Thanks!
If review/merge of this PR takes longer, we probably can consider starting/adding the implementation to this PR.
| // If set to true, ignore the | ||
| // :ref:`immediate_response <envoy_v3_api_field_service.ext_proc.v3.ProcessingResponse.immediate_response>` | ||
| // message in an external processor response. In such case, no local reply will be sent. | ||
| // Instead, The stream to the external processor will be closed. There will be no |
Member
There was a problem hiding this comment.
tiny nit:
Suggested change
| // Instead, The stream to the external processor will be closed. There will be no | |
| // Instead, the stream to the external processor will be closed. There will be no |
Member
|
/retest |
Contributor
Author
|
@envoyproxy/api-shepherds PTAL |
jbohanon
pushed a commit
to solo-io/envoy-fork
that referenced
this pull request
Aug 11, 2023
This is the API change to address issue: envoyproxy#28698 Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
htuch
pushed a commit
that referenced
this pull request
Aug 16, 2023
ashishb-90
pushed a commit
to solo-io/envoy-fork
that referenced
this pull request
Nov 30, 2023
…xy#28989) This is implementation to address issue: envoyproxy#28698. It's a follow up PR of envoyproxy#28907 Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
ashishb-90
pushed a commit
to solo-io/envoy-fork
that referenced
this pull request
Nov 30, 2023
…xy#28989) This is implementation to address issue: envoyproxy#28698. It's a follow up PR of envoyproxy#28907 Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the API change to address issue: #28698
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]