Skip to content

bazel: document how to override a dependency#2818

Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
lizan:override_repository_doc
Mar 15, 2018
Merged

bazel: document how to override a dependency#2818
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
lizan:override_repository_doc

Conversation

@lizan
Copy link
Member

@lizan lizan commented Mar 15, 2018

Description:
Reverts #2781 and document how to use --override_repository.

Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A

@jsedgwick @jmillikin-stripe @htuch

lizan added 2 commits March 14, 2018 19:20
…y repository (envoyproxy#2781)"

This reverts commit 8a0d833.

Signed-off-by: Lizan Zhou <zlizan@google.com>
Signed-off-by: Lizan Zhou <zlizan@google.com>
@lizan lizan force-pushed the override_repository_doc branch from bbc9cc0 to df0f8db Compare March 15, 2018 02:21
@jsedgwick
Copy link

Thanks, LGTM.

It's probably not worth noting in the docs, but JFYI according to bazelbuild/bazel#3728, --override-repository will only work for Bazel repositories, i.e. it won't call new_local_repository() underneath. Doesn't matter for envoy_api which I imagine is the primary use case here.

p.s. it's peculiar that this flag doesn't show up when you google "bazel override repository," which would have saved me some time...

Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. I was also unaware of this CLI flag.

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks @lizan!

@mattklein123 mattklein123 merged commit 5e3fb6e into envoyproxy:master Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants