Skip to content

Fix post-submit clang tidy #27815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phlax merged 2 commits into from
Jun 6, 2023
Merged

Fix post-submit clang tidy #27815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0891aa7
Rename test
ohadvano Jun 6, 2023
3e7d802
Rename test
ohadvano Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/server/config_validation/server_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ class JsonApplicationLogsValidationServerForbiddenFlagvTest : public ValidationS
}
};

class JsonApplicationLogsValidationServerForbiddenFlag_Test : public ValidationServerTest {
class JsonApplicationLogsValidationServerForbiddenFlagUnderscoreTest : public ValidationServerTest {
public:
static void SetUpTestSuite() { // NOLINT(readability-identifier-naming)
setupTestDirectory();
Expand Down Expand Up @@ -306,7 +306,7 @@ INSTANTIATE_TEST_SUITE_P(
::testing::ValuesIn(
JsonApplicationLogsValidationServerForbiddenFlagvTest::getAllConfigFiles()));

TEST_P(JsonApplicationLogsValidationServerForbiddenFlag_Test, TestForbiddenFlag) {
TEST_P(JsonApplicationLogsValidationServerForbiddenFlagUnderscoreTest, TestForbiddenFlag) {
Thread::MutexBasicLockable access_log_lock;
Stats::IsolatedStoreImpl stats_store;
DangerousDeprecatedTestTime time_system;
Expand All @@ -320,9 +320,9 @@ TEST_P(JsonApplicationLogsValidationServerForbiddenFlag_Test, TestForbiddenFlag)
}

INSTANTIATE_TEST_SUITE_P(
AllConfigs, JsonApplicationLogsValidationServerForbiddenFlag_Test,
AllConfigs, JsonApplicationLogsValidationServerForbiddenFlagUnderscoreTest,
::testing::ValuesIn(
JsonApplicationLogsValidationServerForbiddenFlag_Test::getAllConfigFiles()));
JsonApplicationLogsValidationServerForbiddenFlagUnderscoreTest::getAllConfigFiles()));

} // namespace
} // namespace Server
Expand Down
2 changes: 1 addition & 1 deletion test/server/server_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1653,7 +1653,7 @@ TEST_P(ServerInstanceImplTest, JsonApplicationLogFailWithForbiddenFlagv) {
"setJsonLogFormat error: INVALID_ARGUMENT: Usage of %v is unavailable for JSON log formats");
}

TEST_P(ServerInstanceImplTest, JsonApplicationLogFailWithForbiddenFlag_) {
TEST_P(ServerInstanceImplTest, JsonApplicationLogFailWithForbiddenFlagUnderscore) {
EXPECT_THROW_WITH_MESSAGE(
initialize("test/server/test_data/server/json_application_log_forbidden_flag_.yaml"),
EnvoyException,
Expand Down