Skip to content

Fix post-submit clang tidy#27815

Merged
phlax merged 2 commits intoenvoyproxy:mainfrom
ohadvano:fix_clang_tidy
Jun 6, 2023
Merged

Fix post-submit clang tidy#27815
phlax merged 2 commits intoenvoyproxy:mainfrom
ohadvano:fix_clang_tidy

Conversation

@ohadvano
Copy link
Contributor

@ohadvano ohadvano commented Jun 6, 2023

Commit Message: Fixing clang-tidy caused by #27278.
Additional Description: https://dev.azure.com/cncf/envoy/_build/results?buildId=139360&view=logs&j=b7634614-24f3-5416-e791-4f3affaaed6c&t=d565ee52-b888-5d80-7fea-dfaed104c390
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:

ohadvano added 2 commits June 6, 2023 09:04
Signed-off-by: ohadvano <49730675+ohadvano@users.noreply.github.com>
Signed-off-by: ohadvano <49730675+ohadvano@users.noreply.github.com>
@ohadvano
Copy link
Contributor Author

ohadvano commented Jun 6, 2023

/assign @phlax

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @ohadvano

ill try and figure out what is going wrong with the presubmit clang-tidy when i have some time

@phlax phlax enabled auto-merge (squash) June 6, 2023 06:08
@phlax phlax merged commit 3b7328f into envoyproxy:main Jun 6, 2023
@ohadvano ohadvano deleted the fix_clang_tidy branch June 6, 2023 06:56
asheryerm pushed a commit to asheryerm/envoy that referenced this pull request Jul 5, 2023
Signed-off-by: ohadvano <49730675+ohadvano@users.noreply.github.com>
Signed-off-by: asheryer <asheryer@amazon.com>
reskin89 pushed a commit to reskin89/envoy that referenced this pull request Jul 11, 2023
Signed-off-by: ohadvano <49730675+ohadvano@users.noreply.github.com>
Signed-off-by: Ryan Eskin <ryan.eskin89@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants