access_log: pass access log type parameter to evaluate function #27063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ohadvano <[email protected]>
ohadvano
requested review from
wbpcode,
kyessenov,
adisuissa,
lizan,
yanavlasov and
zuercher
as code owners
|
/retest |
|
Retrying Azure Pipelines: |
yanavlasov
approved these changes
May 1, 2023
michaelfinch
added a commit
to michaelfinch/envoy
that referenced
this pull request
May 2, 2023
* main: (175 commits) xds: add config for pick_first LB policy extension (envoyproxy#26952) ci: run Kotlin tests with signal_trace disabled (envoyproxy#27090) ssl: upgrade FIPS boringssl version (envoyproxy#27087) Add createPath to Filesystem abstraction. (envoyproxy#27052) mobile/ci: Increase test_timeout for ios tests (envoyproxy#27044) [mobile]remove Java and GMScore impl from Cronvoy (envoyproxy#27039) Fix compliance issues for iOS builds (envoyproxy#27027) docs: fix the license URL of the dependency "dd-trace-cpp" (envoyproxy#27054) ci/mobile: Hide CI progress in .bazelrc (envoyproxy#27045) thrift_proxy: add access log support for local reply (envoyproxy#27057) ci: Consolidate artifact targets (envoyproxy#27079) lb: moving maglev to extensions (envoyproxy#27037) Overload Manager: LoadShedPoint for HCM decode headers (envoyproxy#26769) Plumb ServerFactoryContext into header validator factory (envoyproxy#27008) access_log: use AccessLogType::NotSet instead of default value (envoyproxy#27058) access_log: pass access log type parameter to evaluate function (envoyproxy#27063) Remove unused member from GrpcStream (envoyproxy#27055) tools: setup build in local_fix_format (envoyproxy#27060) generic proxy: virtual host support for the generic proxy routing (envoyproxy#26932) deps: Bump pytooling publishing deps (envoyproxy#27059) ...
reskin89
pushed a commit
to reskin89/envoy
that referenced
this pull request
Jul 11, 2023
…yproxy#27063) pass access log type parameter to evaluate function Signed-off-by: ohadvano <[email protected]> Signed-off-by: Ryan Eskin <[email protected]>
LanceEa
pushed a commit
to datawire/envoy
that referenced
this pull request
Aug 3, 2023
This covers 3 refactors: 1. BodyFormatter-->format call removed default from last argument. Refactored here: envoyproxy#27034 2. filter _--> evaluate func removed default form last arg making it required. Refactored here: envoyproxy#27063 3. fromProto func removed multiple arguments to support `cel` in access logs. This refactor occured here: envoyproxy#27861 Signed-off-by: Lance Austin <[email protected]>
LanceEa
pushed a commit
to datawire/envoy
that referenced
this pull request
Oct 4, 2023
This covers 3 refactors: 1. BodyFormatter-->format call removed default from last argument. Refactored here: envoyproxy#27034 2. filter _--> evaluate func removed default form last arg making it required. Refactored here: envoyproxy#27063 3. fromProto func removed multiple arguments to support `cel` in access logs. This refactor occured here: envoyproxy#27861 Signed-off-by: Lance Austin <[email protected]>
LanceEa
pushed a commit
to datawire/envoy
that referenced
this pull request
Oct 12, 2023
This covers 3 refactors: 1. BodyFormatter-->format call removed default from last argument. Refactored here: envoyproxy#27034 2. filter _--> evaluate func removed default form last arg making it required. Refactored here: envoyproxy#27063 3. fromProto func removed multiple arguments to support `cel` in access logs. This refactor occured here: envoyproxy#27861 Signed-off-by: Lance Austin <[email protected]>
LanceEa
pushed a commit
to datawire/envoy
that referenced
this pull request
Oct 19, 2023
This covers 3 refactors: 1. BodyFormatter-->format call removed default from last argument. Refactored here: envoyproxy#27034 2. filter _--> evaluate func removed default form last arg making it required. Refactored here: envoyproxy#27063 3. fromProto func removed multiple arguments to support `cel` in access logs. This refactor occured here: envoyproxy#27861 Signed-off-by: Lance Austin <[email protected]>
LanceEa
pushed a commit
to datawire/envoy
that referenced
this pull request
Nov 5, 2023
This covers 3 refactors: 1. BodyFormatter-->format call removed default from last argument. Refactored here: envoyproxy#27034 2. filter _--> evaluate func removed default form last arg making it required. Refactored here: envoyproxy#27063 3. fromProto func removed multiple arguments to support `cel` in access logs. This refactor occured here: envoyproxy#27861 Signed-off-by: Lance Austin <[email protected]>
Alice-Lilith
pushed a commit
to datawire/envoy
that referenced
this pull request
May 9, 2024
This covers 3 refactors: 1. BodyFormatter-->format call removed default from last argument. Refactored here: envoyproxy#27034 2. filter _--> evaluate func removed default form last arg making it required. Refactored here: envoyproxy#27063 3. fromProto func removed multiple arguments to support `cel` in access logs. This refactor occured here: envoyproxy#27861 Signed-off-by: Lance Austin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: access_log: pass access log type parameter to evaluate function
Additional Description: This change is a no-op, a follow up PR will add a new feature to filter access logs based on
AccessLogType(#26755)Risk Level: Low
Testing: None
Docs Changes: None
Release Notes: None
Platform Specific Features: None