xds: add config for pick_first LB policy extension #26952
Conversation
gRPC via the new load_balancing_policy field: * pick_first: This allows configuring the built-in PICK_FIRST LB policy via the new extension-based API. Risk Level: Low Testing: N/A Docs Changes: Included in PR Release Notes: N/A Platform Specific Features: N/A Signed-off-by: Easwar Swaminathan <[email protected]>
|
Hi @easwars, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
| // extension point. See the :ref:`load balancing architecture overview | ||
| // <arch_overview_load_balancing_types>` for more information. |
There was a problem hiding this comment.
Is this going to get implemented in Envoy? Do you have these docs ready? Are you going to submit the code in the final PR? I don't have any context on this, thank you.
/wait-any
There was a problem hiding this comment.
No, I don't expect this to be implemented in Envoy. We do have a pick_first LB policy in gRPC and we want the ability to configure this policy as the leaf policy via the custom LB policy mechanism in xDS. I do have a document out for the changes we are planning to make to the pick_first LB policy which covers this.
@markdroth: Do you want to add anything?
There was a problem hiding this comment.
OK then please remove all the docs and just add the not-implemented-hide annotation. Then you can remove most of the other changes. Thank you.
/wait
There was a problem hiding this comment.
Just to confirm, this is a policy we have in gRPC, but this particular policy is unlikely to be implemented in Envoy.
Adding the not-implemented-hide annotation and removing the Envoy documentation sounds good.
There was a problem hiding this comment.
Can you please remove the arch_voerview stuff also? It's not real. Just have the not-implemented-hide annotation and perhaps a short note that this is currently used in gRPC only. Thanks.
/wait
Signed-off-by: Easwar Swaminathan <[email protected]>
Signed-off-by: Easwar Swaminathan <[email protected]>
* main: (175 commits) xds: add config for pick_first LB policy extension (envoyproxy#26952) ci: run Kotlin tests with signal_trace disabled (envoyproxy#27090) ssl: upgrade FIPS boringssl version (envoyproxy#27087) Add createPath to Filesystem abstraction. (envoyproxy#27052) mobile/ci: Increase test_timeout for ios tests (envoyproxy#27044) [mobile]remove Java and GMScore impl from Cronvoy (envoyproxy#27039) Fix compliance issues for iOS builds (envoyproxy#27027) docs: fix the license URL of the dependency "dd-trace-cpp" (envoyproxy#27054) ci/mobile: Hide CI progress in .bazelrc (envoyproxy#27045) thrift_proxy: add access log support for local reply (envoyproxy#27057) ci: Consolidate artifact targets (envoyproxy#27079) lb: moving maglev to extensions (envoyproxy#27037) Overload Manager: LoadShedPoint for HCM decode headers (envoyproxy#26769) Plumb ServerFactoryContext into header validator factory (envoyproxy#27008) access_log: use AccessLogType::NotSet instead of default value (envoyproxy#27058) access_log: pass access log type parameter to evaluate function (envoyproxy#27063) Remove unused member from GrpcStream (envoyproxy#27055) tools: setup build in local_fix_format (envoyproxy#27060) generic proxy: virtual host support for the generic proxy routing (envoyproxy#26932) deps: Bump pytooling publishing deps (envoyproxy#27059) ...
Signed-off-by: Easwar Swaminathan <[email protected]> Signed-off-by: Ryan Eskin <[email protected]>
This PR adds an LB policy extension configuration, to be used in gRPC via the new
load_balancing_policyfield:pick_first: This allows configuring the built-in PICK_FIRST LB policy via the new extension-based API.Risk Level: Low
Testing: N/A
Docs Changes: Included in PR
Release Notes: N/A
Platform Specific Features: N/A
CC @markdroth