code cleanup: remove unnecessary HttpTracer and HttpTracerSharedPtr#26886
Merged
wbpcode merged 1 commit intoenvoyproxy:mainfrom Apr 25, 2023
Merged
code cleanup: remove unnecessary HttpTracer and HttpTracerSharedPtr#26886wbpcode merged 1 commit intoenvoyproxy:mainfrom
wbpcode merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
wbpcode
requested review from
alyssawilk,
htuch,
lizan and
mattklein123
as code owners
Member
Author
|
I just create this PR for my personally code preference and maybe it's acceptable for the community. |
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
mattklein123
approved these changes
Apr 24, 2023
alyssawilk
added a commit
to alyssawilk/envoy
that referenced
this pull request
Apr 25, 2023
…redPtr (envoyproxy#26886)" This reverts commit 465a1fd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: code cleanup: remove unnecessary HttpTracer and HttpTracerSharedPtr
Additional Description:
In the #24866, we make the
Tracer&TracerManagerprotocol-independent. But theHttpTracerwas kept as a alias ofTracerto reduce the complexity of code review.And this PR just remove the
HttpTracerand clean up the code tree.Risk Level: low. Simple renaming.
Testing: n/a.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.