tracing: make the tracer & tracer manager protocol independent#24866
Merged
wbpcode merged 6 commits intoenvoyproxy:mainfrom Jan 19, 2023
Merged
Conversation
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Member
Author
|
It seems that no mainatainer is in charge of tracing. So, I can only assign this to you first. @mattklein123 🤣 |
added 3 commits
January 11, 2023 07:25
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Member
|
Check CI and then I can have a look? /wait |
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
mattklein123
approved these changes
Jan 17, 2023
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
I looked at this from a refactor perspective, not a code change perspective. From that standpoint it LGTM. I assume there are no logic changes as part of this PR? Thank you.
mum4k
pushed a commit
to envoyproxy/nighthawk
that referenced
this pull request
Jan 24, 2023
- Update .bazelrc --experimental_docker_image - update envoy commit version - update references for Envoy::Tracing::HttpTracerImpl to Envoy::Tracing::TracerImpl based on [#24866](envoyproxy/envoy#24866). Signed-off-by: Chipmunkie <chipmunkie@users.noreply.github.com>
VishalDamgude
pushed a commit
to freshworks-oss/envoy
that referenced
this pull request
Feb 2, 2023
…proxy#24866) * tracing: make the tracer & tracer manager protocol independent Signed-off-by: wbpcode <wangbaiping@corp.netease.com> * fix format Signed-off-by: wbpcode <wangbaiping@corp.netease.com> * minor update Signed-off-by: wbpcode <wangbaiping@corp.netease.com> * fix build Signed-off-by: wbpcode <wangbaiping@corp.netease.com> * fix build 2 Signed-off-by: wbpcode <wangbaiping@corp.netease.com> * fix build 3 Signed-off-by: wbpcode <wangbaiping@corp.netease.com> Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: tracing: make the tracer & tracer manager protocol independent
Additional Description:
By previous PRs (see #15784, #16244, #16793, #17212), We had made the tracing driver protocol independent. The non-HTTP proxy could re-use the all the tracing drivers, such as skywalking, zipkin, etc.
However, the
TracerandTracerManageris still HTTP-specific and the non-HTTP proxy still need to do lots of work to add complete tracing support. And this PR try to make it's easier to add tracing for non-HTTP proxy by:TracerandTracerManagerprotocol independent.Risk Level: mid.
Testing: n/a.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.