Fix weird protobuf string issue with ternary operator.#2653
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Feb 21, 2018
Merged
Conversation
The previous fix in envoyproxy#2648 causes 29 tests to segfault when run with internal string variant (but works fine externally). This version of the fix works fine, all tests pass with all protobuf versions. But why? Testing: bazel test //test/... and the: blaze equivalent internally. Signed-off-by: Dan Noé <dpn@google.com>
htuch
approved these changes
Feb 21, 2018
Member
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Risk Level: n/a Testing: n/a Docs Changes: n/a Release Notes: n/a (hopefully) fixes #2652 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Risk Level: n/a Testing: n/a Docs Changes: n/a Release Notes: n/a (hopefully) fixes #2652 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous fix in #2648
causes 29 tests to segfault when run with internal string variant (but
works fine externally). This version of the fix works fine, all tests
pass with all protobuf versions. But why?
Testing: bazel test //test/...
and the: blaze equivalent internally.
Signed-off-by: Dan Noé dpn@google.com