Use Bazel native build rules for BoringSSL.#2652
Merged
htuch merged 3 commits intoenvoyproxy:masterfrom Feb 22, 2018
Merged
Conversation
Fixes envoyproxy#1549 Signed-off-by: John Millikin <jmillikin@stripe.com>
bazel/repository_locations.bzl
Outdated
| remote = "https://github.com/abseil/abseil-cpp", | ||
| ), | ||
| com_googlesource_boringssl = dict( | ||
| commit = "426db8db7d1cbd17573e295b52d7aab7a97ba1ff", # chromium-64.0.3282.119 |
Contributor
There was a problem hiding this comment.
can you also add chromium-stable-with-bazel as the tag for future reference
Signed-off-by: John Millikin <jmillikin@stripe.com>
PiotrSikora
reviewed
Feb 21, 2018
bazel/repositories.bzl
Outdated
| ) | ||
|
|
||
| def _com_googlesource_boringssl(): | ||
| _repository_impl("com_googlesource_boringssl") |
Contributor
There was a problem hiding this comment.
This is wrong. While you're trying to come up with "semi-standard" name, you're ignoring the boringssl name provided in BoringSSL's WORKSPACE, which leads to a build time warning:
WARNING: /build/tmp/_bazel_bazel/436badd4919a15958fa3800a4e21074a/external/com_googlesource_boringssl/WORKSPACE:1: Workspace name in /build/tmp/_bazel_bazel/436badd4919a15958fa3800a4e21074a/external/com_googlesource_boringssl/WORKSPACE (@boringssl) does not match the name given in the repository's definition (@com_googlesource_boringssl); this will cause a build error in future versions
Contributor
Author
There was a problem hiding this comment.
Oops, I'd been looking at the chromium-stable branch and forgot WORKSPACE was populated in chromium-stable-with-bazel. Fixed.
Signed-off-by: John Millikin <jmillikin@stripe.com>
danielhochman
approved these changes
Feb 21, 2018
PiotrSikora
approved these changes
Feb 21, 2018
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Risk Level: n/a Testing: n/a Docs Changes: n/a Release Notes: n/a (hopefully) fixes #2652 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Risk Level: n/a Testing: n/a Docs Changes: n/a Release Notes: n/a (hopefully) fixes #2652 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Now that we've fixed the CC vs CXX compiler situation, we can safely build BoringSSL using its native Bazel rules.
The commit ID change is because BoringSSL's BUILD rules are maintained on a separate branch, which gets merges from "chromium-stable". The commit 426db8 is the merge of a20bb7.
Fixes #1549
Risk Level: Low
Signed-off-by: John Millikin jmillikin@stripe.com
Testing:
I built and tested this locally on a MacOS machine with Clang. Will depend on CI to test with other configurations.