Skip to content

listen_socket: Remove default value from virtual function parameter. #2573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattklein123 merged 1 commit into from
Feb 9, 2018
Merged

listen_socket: Remove default value from virtual function parameter. #2573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/envoy/network/listen_socket.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ class ConnectionSocket : public virtual Socket {
* actually different when passing restored as 'true'.
*/
virtual void setLocalAddress(const Address::InstanceConstSharedPtr& local_address,
bool restored = false) PURE;
bool restored) PURE;

/**
* Set the remote address of the socket.
Expand Down
2 changes: 1 addition & 1 deletion source/common/filter/listener/proxy_protocol.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ void Instance::onReadWorker() {
throw EnvoyException("failed to read proxy protocol");
}

socket.setLocalAddress(local_address);
socket.setLocalAddress(local_address, false);
socket.setRemoteAddress(remote_address);
}

Expand Down
2 changes: 1 addition & 1 deletion source/common/network/connection_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,7 @@ void ClientConnectionImpl::connect() {
// The local address can only be retrieved for IP connections. Other
// types, such as UDS, don't have a notion of a local address.
if (socket_->remoteAddress()->type() == Address::Type::Ip) {
socket_->setLocalAddress(Address::addressFromFd(fd()));
socket_->setLocalAddress(Address::addressFromFd(fd()), false);
}
}

Expand Down