listen_socket: Remove default value from virtual function parameter.#2573
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Feb 9, 2018
Merged
Conversation
We should not have default parameter values on virtual functions, but this one slipped through. Fixes: eb02089 ("Listener: Add listener filters. (envoyproxy#2346)") Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
dnoe
approved these changes
Feb 9, 2018
mattklein123
approved these changes
Feb 9, 2018
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should not have default parameter values on virtual functions, but
this one slipped through.
Fixes: eb02089 ("Listener: Add listener filters. (#2346)")
Signed-off-by: Jarno Rajahalme jarno@covalent.io
Risk Level: Low