Skip to content

docker/ci: Add debugging info #25626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phlax merged 1 commit into from
Feb 20, 2023
Merged

docker/ci: Add debugging info #25626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 44 additions & 2 deletions ci/docker_ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,26 @@
# CI logs.
set -e

## DEBUGGING (NB: Set these in your env to avoided unwanted changes)
## Set this to _not_ build/push just print what would be
# DOCKER_CI_DRYRUN=true
#
## Set these to tag/push images to your own repo
# DOCKER_IMAGE_PREFIX=mydocker/repo
# DOCKERHUB_USERNAME=me
# DOCKERHUB_PASSWORD=mypassword
#
## Set these to simulate types of CI run
# AZP_SHA1=MOCKSHA
# AZP_BRANCH=refs/heads/main
# AZP_BRANCH=refs/heads/release/v1.43
# AZP_BRANCH=refs/tags/v1.77
##

if [[ -n "$DOCKER_CI_DRYRUN" ]]; then
AZP_SHA1="${AZP_SHA1:-MOCKSHA}"
fi

function is_windows() {
[[ "$(uname -s)" == *NT* ]]
}
Expand Down Expand Up @@ -73,7 +93,15 @@ build_images() {
args+=("-o" "type=oci,dest=${ENVOY_DOCKER_IMAGE_DIRECTORY}/envoy${TYPE}.tar")
fi

echo ">> BUILD: ${BUILD_TAG}"
echo "> docker ${BUILD_COMMAND[*]} --platform ${PLATFORM} ${args[*]} -t ${BUILD_TAG} ."
if [[ -n "$DOCKER_CI_DRYRUN" ]]; then
echo ""
return
fi
echo "..."
docker "${BUILD_COMMAND[@]}" --platform "${PLATFORM}" "${args[@]}" -t "${BUILD_TAG}" .
echo ""
}

push_images() {
Expand All @@ -85,9 +113,19 @@ push_images() {
_args=$(build_args "${TYPE}")
read -ra args <<<"$_args"
PLATFORM="$(build_platforms "${TYPE}")"

echo ">> PUSH: ${BUILD_TAG}"
echo "> docker ${BUILD_COMMAND[*]} --platform ${PLATFORM} ${args[*]} -t ${BUILD_TAG} . --push ||
docker push ${BUILD_TAG}"
if [[ -n "$DOCKER_CI_DRYRUN" ]]; then
echo ""
return
fi
echo "..."
# docker buildx doesn't do push with default builder
docker "${BUILD_COMMAND[@]}" --platform "${PLATFORM}" "${args[@]}" -t "${BUILD_TAG}" . --push ||
docker push "${BUILD_TAG}"
echo ""

@wbpcode wbpcode Feb 20, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this necessary?

@phlax phlax Feb 20, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it makes it easier to parse the output - ie it separates the blocks

}

MAIN_BRANCH="refs/heads/main"
Expand Down Expand Up @@ -118,7 +156,9 @@ else

# Configure docker-buildx tools
BUILD_COMMAND=("buildx" "build")
config_env
if [[ -z "$DOCKER_CI_DRYRUN" ]]; then
config_env
fi
fi

# Test the docker build in all cases, but use a local tag that we will overwrite before push in the
Expand All @@ -136,7 +176,9 @@ if [[ "${AZP_BRANCH}" != "${MAIN_BRANCH}" ]] &&
exit 0
fi

docker login -u "$DOCKERHUB_USERNAME" -p "$DOCKERHUB_PASSWORD"
if [[ -z "$DOCKER_CI_DRYRUN" ]]; then
docker login -u "$DOCKERHUB_USERNAME" -p "$DOCKERHUB_PASSWORD"
fi

for BUILD_TYPE in "${BUILD_TYPES[@]}"; do
push_images "${BUILD_TYPE}" "${DOCKER_IMAGE_PREFIX}${BUILD_TYPE}${IMAGE_POSTFIX}:${IMAGE_NAME}"
Expand Down