Merged
Conversation
Member
Author
|
@lizan i think we should add this first before making too much changes in the docker ci file as its a bit complex and hard to track one thing running this reveals straight away is that (at least with the context i was testing) the release images are pushed (afaict needlessly) a second time - not sure if we can just remove - windows is a factor |
phlax
commented
Feb 17, 2023
phlax
force-pushed
the
ci-docker-debug
branch
2 times, most recently
from
f4590de to
f37d4a6
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
ci-docker-debug
branch
from
f37d4a6 to
6fc63e5
Compare
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
wbpcode
reviewed
Feb 20, 2023
| # docker buildx doesn't do push with default builder | ||
| docker "${BUILD_COMMAND[@]}" --platform "${PLATFORM}" "${args[@]}" -t "${BUILD_TAG}" . --push || | ||
| docker push "${BUILD_TAG}" | ||
| echo "" |
Member
Author
There was a problem hiding this comment.
it makes it easier to parse the output - ie it separates the blocks
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Feb 22, 2023
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax
added a commit
that referenced
this pull request
Feb 22, 2023
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Feb 23, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Feb 23, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
that referenced
this pull request
Feb 27, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
that referenced
this pull request
Feb 27, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Feb 28, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
that referenced
this pull request
Mar 1, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]