Update data-plane-api (second attempt)#2472
Merged
mattklein123 merged 7 commits intoenvoyproxy:masterfrom Jan 30, 2018
Merged
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
This was referenced Jan 29, 2018
Contributor
Author
|
I cannot reproduce ASAN failure: |
Member
|
Yes, this is a flake in my recent change. I'm going to roll it back while I fix. |
Member
|
@kyessenov I suspect this is related to @htuch change but not sure. He can take a look. |
Member
|
LGTM once we get the merge conflicts and flake sorted out. |
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Member
|
@junr03 can you manually test this branch at Lyft very quickly just to make sure it works. Would just like a quick sanity test. |
htuch
approved these changes
Jan 29, 2018
mattklein123
approved these changes
Jan 30, 2018
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
@junr03 please merge assuming smoke test looks good. Thank you @kyessenov!!!
junr03
approved these changes
Jan 30, 2018
Member
junr03
left a comment
junr03
left a comment
There was a problem hiding this comment.
just put on our staging edge proxy at Lyft, and I am seeing endpoints from our sds service and xDS updates from our management server.
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
* adding new tests Signed-off-by: Kuat Yessenov <kuat@google.com> * update go mod Signed-off-by: Kuat Yessenov <kuat@google.com> * add stackdriver test Signed-off-by: Kuat Yessenov <kuat@google.com> * test: add xDS test framework for SD Signed-off-by: Kuat Yessenov <kuat@google.com> * add concurrent xds and data path Signed-off-by: Kuat Yessenov <kuat@google.com> * fix lint Signed-off-by: Kuat Yessenov <kuat@google.com> * bump up the duration Signed-off-by: Kuat Yessenov <kuat@google.com> * dont run in parallel yet Signed-off-by: Kuat Yessenov <kuat@google.com> * add delay to avoid CPU bomb Signed-off-by: Kuat Yessenov <kuat@google.com> * add delays Signed-off-by: Kuat Yessenov <kuat@google.com> * slow down activation Signed-off-by: Kuat Yessenov <kuat@google.com> * fix envoy binary path Signed-off-by: Kuat Yessenov <kuat@google.com> * update base envoy Signed-off-by: Kuat Yessenov <kuat@google.com> * use ports from env Signed-off-by: Kuat Yessenov <kuat@google.com> * merge fix Signed-off-by: Kuat Yessenov <kuat@google.com> * re-organize Signed-off-by: Kuat Yessenov <kuat@google.com> * re-organize Signed-off-by: Kuat Yessenov <kuat@google.com> * CI... Signed-off-by: Kuat Yessenov <kuat@google.com> * CI... Signed-off-by: Kuat Yessenov <kuat@google.com> * CI... Signed-off-by: Kuat Yessenov <kuat@google.com> * annoying CI Signed-off-by: Kuat Yessenov <kuat@google.com> * force fastbuild Signed-off-by: Kuat Yessenov <kuat@google.com> * ugh Signed-off-by: Kuat Yessenov <kuat@google.com> * fix bazel arch Signed-off-by: Kuat Yessenov <kuat@google.com> * ugh Signed-off-by: Kuat Yessenov <kuat@google.com> * ugh Signed-off-by: Kuat Yessenov <kuat@google.com> * ugh Signed-off-by: Kuat Yessenov <kuat@google.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: Connect Cronet's enableQuic() call with Envoy-mobile's QUIC knob. Additional Description: Note that with the change, Cronvoy will no longer force any request into the h2 only cluster. Risk Level: Low Testing: n/a Docs Changes: n/a Release Notes: n/a Signed-off-by: Renjie Tang <renjietang@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: Connect Cronet's enableQuic() call with Envoy-mobile's QUIC knob. Additional Description: Note that with the change, Cronvoy will no longer force any request into the h2 only cluster. Risk Level: Low Testing: n/a Docs Changes: n/a Release Notes: n/a Signed-off-by: Renjie Tang <renjietang@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
title: Update data plane API to pick refactoring
Description:
Applies refactoring of packages to Envoy code.
Risk Level: Medium (previous attempt caused problems rolling out changes due to incompatibility with the management servers)
Testing:
No functional change.
Docs Changes:
envoyproxy/data-plane-api#438 (comment)
Release Notes: