Skip to content

Update data-plane-api (second attempt)#2468

Closed
kyessenov wants to merge 1 commit intoenvoyproxy:masterfrom
kyessenov:packages_fix
Closed

Update data-plane-api (second attempt)#2468
kyessenov wants to merge 1 commit intoenvoyproxy:masterfrom
kyessenov:packages_fix

Conversation

@kyessenov
Copy link
Copy Markdown
Contributor

Signed-off-by: Kuat Yessenov kuat@google.com

title: one line description

Title can be a one or two words to describe the subsystem or the aspect
this PR applies to. Title and description must be lower case. For example:

  • ci: update build image to 44d539c
  • docs: fix indent, buffer: add copyOut() method
  • router:add x-envoy-overloaded header
  • tls: add support for specifying TLS session ticket keys

Description:

What does this PR do? What was the behavior before the PR?
What is the behavior with the PR? If fixing a bug, please describe what
the original issue is and how the change resolves it. How does this
feature get enabled? By default, config change, etc...

Risk Level: Low | Medium | High

Low: Small bug fix or small optional feature.

Medium: New features that are not enabled(for example: new filter). Small-medium
features added to existing components(for example: modification to an existing
filter).

High: Complicated changes such as flow control, rewrites of critical
components, etc.

Note: The above is only a rough guide for choosing a level,
please ask if you have any concerns about the risk of the PR.

Testing:

Explanation of what testing was done, for example: unit test,
integration, manual testing, etc.

Note: It isn’t expected to do all
forms of testing, please use your best judgement or ask for guidance
if you are unsure. A good rule of thumb is the riskier the change, the
more comprehensive the testing should be.

Docs Changes:

Link to Data Plane PR]
if your PR involves documentation changes. Please write in N/A if there were no
documentation changes.

Release Notes:

If this change is user impacting you must add a release note to
RAW_RELEASE_NOTES.md. Thank you! Please write in N/A if
there are no release notes.

[Optional Fixes #Issue]

[Optional API Changes:]

Link to Data Plane PR]

[Optional Deprecated:]

Description of what is deprecated.

Signed-off-by: Kuat Yessenov <kuat@google.com>
@alyssawilk
Copy link
Copy Markdown
Contributor

@htuch @mattklein123 I figure you two are best since you reviewed #2430

@kyessenov Thanks for taking a second pass at this one. Do you mind updating the description on this PR to remove the things the template added, and fill in the relevant fields?

@mattklein123
Copy link
Copy Markdown
Member

@kyessenov can we update this w/ the new version of your data-plane-api PR to look at it?

@kyessenov kyessenov closed this Jan 29, 2018
@kyessenov
Copy link
Copy Markdown
Contributor Author

I opened another PR: #2472

Shikugawa pushed a commit to Shikugawa/envoy that referenced this pull request Mar 28, 2020
…xy#2468)

* feat(edges): enable edge reporting in stackdriver extension

Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>

* fix(edges): add stats_prefix and change reporting duration

Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>

* fix: remove unused constexpr

Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>
jpsim pushed a commit that referenced this pull request Nov 28, 2022
Signed-off-by: Renjie Tang <renjietang@chromium.org>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
Signed-off-by: Renjie Tang <renjietang@chromium.org>
Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants