-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update proxy-wasm-cpp-host #23460
Conversation
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
not sure what I'm in for here |
cc @kfaseela |
923df42
to
4f0b5bd
Compare
Fixes envoyproxy#23390 Signed-off-by: Keith Smiley <[email protected]>
4f0b5bd
to
af5a750
Compare
I removed the v8 version bump from this one to only take that bazel fix, if we can land yours instead w/o other blockers we should do that and close this one |
im not sure - previously i believe there was a need to update these deps together (and do some cargo-fu) it seems like they are not in sync now - altho maybe the important deps are Envoy's version of wasmtime: envoy/bazel/repository_locations.bzl Lines 982 to 996 in 7a4bbb3
which is using a recent hash version (maybe we should switch to a releaese version there) current wasmtime upstream https://github.com/bytecodealliance/wasmtime/releases/tag/v1.0.1 but it doesnt seem like the wasmtime crates have been updated: |
There are only 2 commits being pulled in with this change proxy-wasm/proxy-wasm-cpp-host@4fcf895...25d6a99 so if the other change is blocked on anything I would think updating this would be pretty safe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems like they are not in sync now - altho maybe the important deps are
They are not. Wasmtime is out-of-sync and it only works by accident because there were no breaking changes in Wasmtime's C API (updated in #23232), but Envoy is now using C API from a version different than Wasmtime core.
@RiverPhillips is working on fixing that in proxy-wasm/proxy-wasm-cpp-host#309, and hopefully we can land it and merge into Envoy before the next release.
Regarding this PR, it can be either merged as-is or it could be dropped in favor of #23434, which also contains those changes and was opened first.
Maybe just do #23434? |
Fixes #23390
Signed-off-by: Keith Smiley [email protected]