Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Bump v8 to 10.7.193.13 and proxy_wasm_cpp_host to b0a0594 #23434

Merged
merged 9 commits into from
Oct 18, 2022
Merged

deps: Bump v8 to 10.7.193.13 and proxy_wasm_cpp_host to b0a0594 #23434

merged 9 commits into from
Oct 18, 2022

Conversation

dio
Copy link
Member

@dio dio commented Oct 11, 2022 •
edited
Loading

Commit Message: Update v8 to 10.7.193.13 and proxy_wasm_cpp_host to proxy-wasm/proxy-wasm-cpp-host@b0a0594.
Risk Level: Medium (but mostly wasm related)
Additional Description: In the process, we remove com_googlesource_chromium_zlib, since now v8 can be compiled without it and can be ignored: #23258 (comment).

Fixes #23258 #23390

Signed-off-by: Dhi Aurrahman [email protected]

@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #23434 was opened by dio.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 11, 2022
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @wrowe

🐱

Caused by: #23434 was opened by dio.

see: more, trace.

@dio
deps: Bump v8 -> 10.7.193.13
e7e3181 
Signed-off-by: Dhi Aurrahman <[email protected]>
@dio dio changed the title WIP: deps: Bump v8 to 10.7.193.13 and proxy_wasm_cpp_host to b0a0594 WIP: deps: Bump v8 to 10.7.193.13 and proxy_wasm_cpp_host to b0a0594 Oct 11, 2022
@dio
Wrong URL
5e1607e 
Signed-off-by: Dhi Aurrahman <[email protected]>
@dio
Fix date
58a862c 
Signed-off-by: Dhi Aurrahman <[email protected]>
@dio
Fix wee8_compile
61ca61b 
Signed-off-by: Dhi Aurrahman <[email protected]>
@wrowe
Copy link
Contributor

wrowe commented Oct 12, 2022

As this is still WIP, can we presume it targets main branch once the pending release has dropped around the 15th?

@dio
Update bucket
828fe87 
Signed-off-by: Dhi Aurrahman <[email protected]>
@dio
Copy link
Member Author

dio commented Oct 12, 2022

Seems like it carries a fix for #23390 too.

@dio dio mentioned this pull request Oct 12, 2022
Closed
@dio dio changed the title WIP: deps: Bump v8 to 10.7.193.13 and proxy_wasm_cpp_host to b0a0594 deps: Bump v8 to 10.7.193.13 and proxy_wasm_cpp_host to b0a0594 Oct 12, 2022
@dio dio marked this pull request as ready for review October 12, 2022 21:37
@dio
Copy link
Member Author

dio commented Oct 12, 2022 •
edited
Loading

@wrowe the bucket that provides the v8 snapshot is updated (thanks to @mpwarres). Now, this is ready to review.

cc. @keith @phlax @PiotrSikora @envoyproxy/wasm-dev

PiotrSikora
PiotrSikora previously approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc @mpwarres

bazel/v8.patch Outdated Show resolved Hide resolved
PiotrSikora
PiotrSikora previously approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@phlax
Copy link
Member

phlax commented Oct 13, 2022

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23434 (comment) was created by @phlax.

see: more, trace.

wrowe
wrowe suggested changes Oct 13, 2022
View reviewed changes
bazel/repository_locations.bzl Outdated Show resolved Hide resolved
@dio
Fix date
472c1b2 
Signed-off-by: Dhi Aurrahman <[email protected]>
@dio
Fix again
dd57789 
Signed-off-by: Dhi Aurrahman <[email protected]>
@wrowe
Copy link
Contributor

wrowe commented Oct 13, 2022

/lgtm deps

Thanks, for dropping a dependency this deserves to land in the release. Appreciated!

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Oct 13, 2022
@dio
Copy link
Member Author

dio commented Oct 14, 2022

Thanks, @wrowe! Seems like we need your PR review approval as well. :)

@wrowe
Copy link
Contributor

wrowe commented Oct 14, 2022

@PiotrSikora, @lizan this has all it's stamps. Please apply today if you feel certain it is beneficial and not disruptive to the imminent release tag.

phlax
phlax approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @dio

@phlax phlax merged commit 2c582bd into envoyproxy:main Oct 18, 2022
@dio
Copy link
Member Author

dio commented Oct 18, 2022

Thanks, for merging @phlax! macOS 1.24.x build for homebrew will be interesting!

@dio dio deleted the bump_v8_10.7.193.13 branch October 19, 2022 05:03
@keith keith mentioned this pull request Oct 25, 2022
Closed
phlax pushed a commit to phlax/envoy that referenced this pull request Nov 23, 2022
@dio @phlax
deps: Bump v8 to 10.7.193.13 and proxy_wasm_cpp_host to b0a0594 (e…
be8b17f 
…nvoyproxy#23434)

Signed-off-by: Dhi Aurrahman <[email protected]>
phlax pushed a commit to phlax/envoy that referenced this pull request Nov 23, 2022
@dio @phlax
deps: Bump v8 to 10.7.193.13 and proxy_wasm_cpp_host to b0a0594 (e…
9796b72 
…nvoyproxy#23434)

Signed-off-by: Dhi Aurrahman <[email protected]>
phlax pushed a commit to phlax/envoy that referenced this pull request Nov 24, 2022
@dio @phlax
deps: Bump v8 to 10.7.193.13 and proxy_wasm_cpp_host to b0a0594 (e…
be11229 
…nvoyproxy#23434)

Signed-off-by: Dhi Aurrahman <[email protected]>

Signed-off-by: Ryan Northey <[email protected]>
phlax pushed a commit that referenced this pull request Nov 26, 2022
@dio @phlax
deps: Bump v8 to 10.7.193.13 and proxy_wasm_cpp_host to b0a0594 (#…
f4486ed 
…23434)

Signed-off-by: Dhi Aurrahman <[email protected]>

Signed-off-by: Ryan Northey <[email protected]>
phlax added a commit that referenced this pull request Nov 30, 2022
@phlax @RiverPhillips
@PiotrSikora @keith @dio
[backport/1.22] deps: Bump com_github_wasmtime -> 2.0.2 (#24086) (#…
b4f4d21 
…24089)

* deps: bump `com_github_wasmtime` -> 1.0.0 (#23232)

Signed-off-by: river phillips <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>

* wasm: update WAVM to nightly/2022-05-14. (#22491)


Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>

* wasm: update Proxy-Wasm C++ Host to latest. (#22575)

Signed-off-by: Piotr Sikora <[email protected]>

Signed-off-by: Ryan Northey <[email protected]>

* deps: Bump `com_github_wasmtime` -> 1.0.2 (#24086)

Fix:

- CVE-2022-39392
- CVE-2022-39393
- CVE-2022-39394

Signed-off-by: Ryan Northey <[email protected]>

* bazel: update rules_rust

This gets us on rust 1.60

Signed-off-by: Keith Smiley <[email protected]>

Signed-off-by: Ryan Northey <[email protected]>

* deps: Bump `rules_rust` -> 0.8.1 (#22253)

Fix #22073

Signed-off-by: Ryan Northey <[email protected]>

* wasm: fix V8 build on older versions of Linux. (#22228)

wasm: fix build on older versions of Linux.

Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>

* backport: macOS: Allow to load .wasm on Apple silicon (#23299)

backport: macOS: Enable wasm and allow to load .wasm on Apple silicon

This applies https://chromium-review.googlesource.com/c/v8/v8/+/3700352 as a fix for
MemoryAllocator::PartialFreeMemory() which shouldn't try to change permissions of RWX pages.

This mainly affects macOS > 11.2 due to mprotect behavior changes (#23243)
on Apple silicon.

This is cherry-picked from: 63f27a6

Signed-off-by: Dhi Aurrahman <[email protected]>

Signed-off-by: Dhi Aurrahman <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>

* deps: Bump `v8` to 10.7.193.13 and `proxy_wasm_cpp_host` to b0a0594 (#23434)

Signed-off-by: Dhi Aurrahman <[email protected]>

* ci: Disable wasm coverage tests (#24169)

and adjust-coverage-total

Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>

* deps: Bump `com_github_wasmtime` -> 2.0.2 (+related) (#24150)

deps: Bump `com_github_wasmtime` -> 2.0.2

- `proxy_wasm_cpp_host`
- `proxy_wasm_rust_sdk`

Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: river phillips <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Dhi Aurrahman <[email protected]>
Signed-off-by: phlax <[email protected]>
Co-authored-by: River <[email protected]>
Co-authored-by: Piotr Sikora <[email protected]>
Co-authored-by: Keith Smiley <[email protected]>
Co-authored-by: Dhi Aurrahman <[email protected]>
phlax pushed a commit that referenced this pull request Dec 3, 2022
@dio @phlax
deps: Bump v8 to 10.7.193.13 and proxy_wasm_cpp_host to b0a0594 (#…
d0958bf 
…23434)

Signed-off-by: Dhi Aurrahman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wrowe wrowe wrowe approved these changes

@PiotrSikora PiotrSikora PiotrSikora approved these changes

@phlax phlax phlax approved these changes

Assignees

@wrowe wrowe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove mprotect()/rwx-related patch entry from bazel/v8.patch
4 participants
@dio @wrowe @phlax @PiotrSikora