Skip to content

Listener: the API change for multiple addresses support #21391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattklein123 merged 9 commits into from
Jun 9, 2022
Merged

Listener: the API change for multiple addresses support #21391

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2b8f0d4
listener: add new `additional_addresses` to the listener API
soulxu May 20, 2022
4ccdb05
change admin API
soulxu May 20, 2022
33097ed
fix typo
soulxu May 20, 2022
1f96eb8
bump the next free field
soulxu May 20, 2022
0595758
address comments
soulxu May 26, 2022
731509a
Merge branch 'main' into multiple_addresses_for_listener_api
soulxu Jun 6, 2022
7f34049
Address comments
soulxu Jun 6, 2022
7a2bf3b
address comments
soulxu Jun 8, 2022
542c094
remove repeated
soulxu Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions api/envoy/admin/v3/listeners.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,9 @@ message ListenerStatus {
// The actual local address that the listener is listening on. If a listener was configured
// to listen on port 0, then this address has the port that was allocated by the OS.
config.core.v3.Address local_address = 2;

// The additional addresses the listener is listening on as specified via the :ref:`additional_addresses <envoy_v3_api_field_config.listener.v3.Listener.additional_addresses>`
// configuration.
// [#not-implemented-hide:]
repeated config.core.v3.Address additional_local_addresses = 3;
}
14 changes: 13 additions & 1 deletion api/envoy/config/listener/v3/listener.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,19 @@ option (udpa.annotations.file_status).package_version_status = ACTIVE;
// [#protodoc-title: Listener configuration]
// Listener :ref:`configuration overview <config_listeners>`

// The additional address the listener is listening on.
// [#not-implemented-hide:]
message AdditionalAddress {
repeated core.v3.Address address = 1;
Comment thread
soulxu marked this conversation as resolved.
Outdated
}

// Listener list collections. Entries are *Listener* resources or references.
// [#not-implemented-hide:]
message ListenerCollection {
repeated xds.core.v3.CollectionEntry entries = 1;
}

// [#next-free-field: 33]
// [#next-free-field: 34]
message Listener {
option (udpa.annotations.versioning).previous_message_type = "envoy.api.v2.Listener";

Expand Down Expand Up @@ -109,6 +115,12 @@ message Listener {
// Required unless *api_listener* or *listener_specifier* is populated.
core.v3.Address address = 2;

// The additional addresses the listener should listen on. The addresses must be unique across all
// listeners. Multiple addresses with port 0 can be supplied. When using multiple addresses in a single listener,
// all addresses use the same protocol, and multiple internal addresses are not supported.
// [#not-implemented-hide:]
repeated AdditionalAddress additional_addresses = 33;

// Optional prefix to use on listener stats. If empty, the stats will be rooted at
// `listener.<address as string>.`. If non-empty, stats will be rooted at
// `listener.<stat_prefix>.`.
Expand Down