Listener: the API change for multiple addresses support by soulxu · Pull Request #21391 · envoyproxy/envoy

soulxu · 2022-05-20T05:57:42Z

Commit Message: Listener: the API change for multiple addresses support
Additional Description:

Both listener and admin API are changed to support multiple addresses.

Risk Level: low
Testing: n/a
Docs Changes: API doc
Release Notes: n/a
Platform Specific Features: n/a
Part of Fixes #11184

Signed-off-by: He Jie Xu <hejie.xu@intel.com>

repokitteh-read-only · 2022-05-20T05:57:49Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @adisuissa
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #21391 was opened by soulxu.

see: more, trace.

soulxu · 2022-05-20T05:58:01Z

This the API change separated from #19367

api/envoy/config/listener/v3/listener.proto

Signed-off-by: He Jie Xu <hejie.xu@intel.com>

mattklein123

Thanks a few comments.

/wait

api/envoy/admin/v3/listeners.proto

api/envoy/config/listener/v3/listener.proto

Signed-off-by: He Jie Xu <hejie.xu@intel.com>

soulxu · 2022-05-27T03:43:29Z

/retest

repokitteh-read-only · 2022-05-27T03:43:33Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #21391 (comment) was created by @soulxu.

see: more, trace.

soulxu · 2022-05-27T22:45:00Z

seems CI issue also. not waste resources to retest again.

soulxu · 2022-06-02T01:11:14Z

/retest

repokitteh-read-only · 2022-06-02T01:11:19Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #21391 (comment) was created by @soulxu.

see: more, trace.

soulxu · 2022-06-02T06:55:18Z

/retest

repokitteh-read-only · 2022-06-02T06:55:23Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #21391 (comment) was created by @soulxu.

see: more, trace.

soulxu · 2022-06-02T13:12:41Z

emm...why this keep failure, is that my problem? is it just a timeout https://dev.azure.com/cncf/envoy/_build/results?buildId=109367&view=logs&j=9847b632-4506-56d9-5b24-dbc653a96189&t=77343030-d1d4-546e-4c1c-b92bbd14ed15&l=76

Signed-off-by: He Jie Xu <hejie.xu@intel.com>

soulxu · 2022-06-06T08:18:18Z

The CI passed after merge with main

mattklein123

LGTM with small comments, thanks.

/wait

api/envoy/admin/v3/listeners.proto

api/envoy/config/listener/v3/listener.proto

Signed-off-by: He Jie Xu <hejie.xu@intel.com>

mattklein123

Thanks LGTM with a small comment.

/wait

api/envoy/admin/v3/listeners.proto

ggreenway

Before finalizing this, I just want to confirm that we do NOT think we need any other data with each address. Some examples of things that might be useful, but possibly none of these are needed:

different socket options
different stat prefix (if no stat-prefix is specified, we currently use the address as the stat-prefix; if a stat-prefix is specified then there's no way to get different stats for the different addresses)
anything related to internal listeners (cc @lambdai)
different value of freebind

Adding a message to repeat here gives us the ability to add more settings in the future if we need to, so it seems more future-proof.

Another way of thinking about it: the result of this is that additional listening sockets are setup. Will we ever need to set configuration to change any of the settings that are on a socket, to be different between the different addresses on the same envoy listener?

mattklein123 · 2022-06-07T16:17:50Z

Adding a message to repeat here gives us the ability to add more settings in the future if we need to, so it seems more future-proof.

Yeah I like this idea. Good point. Let's do it.

soulxu · 2022-06-08T05:27:05Z

different stat prefix (if no stat-prefix is specified, we currently use the address as the stat-prefix; if a stat-prefix is specified then there's no way to get different stats for the different addresses)

At least ensure that we already consider the pre-address stat prefix, but it is too complex for now. Thanks for the good point! let me update the PR

Signed-off-by: He Jie Xu <hejie.xu@intel.com>

soulxu · 2022-06-08T11:30:36Z

/retest

repokitteh-read-only · 2022-06-08T11:30:40Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #21391 (comment) was created by @soulxu.

see: more, trace.

mattklein123

LGTM, thanks. Will defer to @ggreenway for approve/merge.

ggreenway

/wait

api/envoy/config/listener/v3/listener.proto

Signed-off-by: He Jie Xu <hejie.xu@intel.com>

soulxu · 2022-06-09T05:32:15Z

/retest

repokitteh-read-only · 2022-06-09T05:32:19Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #21391 (comment) was created by @soulxu.

see: more, trace.

soulxu · 2022-06-09T12:20:41Z

@mattklein123 sorry, I lost your approval since I updated the PR :)

…1391) Signed-off-by: He Jie Xu <hejie.xu@intel.com> Signed-off-by: Tianyu Xia <tyxia@google.com>

…1391) Signed-off-by: He Jie Xu <hejie.xu@intel.com> Signed-off-by: Amila Senadheera <amila.15@cse.mrt.ac.lk>

soulxu added 2 commits May 20, 2022 05:51

listener: add new additional_addresses to the listener API

2b8f0d4

Signed-off-by: He Jie Xu <hejie.xu@intel.com>

change admin API

4ccdb05

Signed-off-by: He Jie Xu <hejie.xu@intel.com>

repokitteh-read-only bot added the api label May 20, 2022

repokitteh-read-only bot assigned adisuissa May 20, 2022

soulxu commented May 20, 2022

View reviewed changes

api/envoy/config/listener/v3/listener.proto Outdated Show resolved Hide resolved

soulxu added 2 commits May 20, 2022 06:49

fix typo

33097ed

Signed-off-by: He Jie Xu <hejie.xu@intel.com>

bump the next free field

1f96eb8

Signed-off-by: He Jie Xu <hejie.xu@intel.com>

soulxu mentioned this pull request May 26, 2022

listener: support multiple addresses #19367

Closed

mattklein123 self-assigned this May 26, 2022

mattklein123 requested changes May 26, 2022

View reviewed changes

api/envoy/admin/v3/listeners.proto Outdated Show resolved Hide resolved

api/envoy/config/listener/v3/listener.proto Outdated Show resolved Hide resolved

repokitteh-read-only bot added the waiting label May 26, 2022

address comments

0595758

Signed-off-by: He Jie Xu <hejie.xu@intel.com>

repokitteh-read-only bot removed the waiting label May 26, 2022

Merge branch 'main' into multiple_addresses_for_listener_api

731509a

Signed-off-by: He Jie Xu <hejie.xu@intel.com>

mattklein123 requested changes Jun 6, 2022

View reviewed changes

api/envoy/admin/v3/listeners.proto Outdated Show resolved Hide resolved

api/envoy/config/listener/v3/listener.proto Outdated Show resolved Hide resolved

repokitteh-read-only bot added the waiting label Jun 6, 2022

Address comments

7f34049

Signed-off-by: He Jie Xu <hejie.xu@intel.com>

repokitteh-read-only bot removed the waiting label Jun 6, 2022

mattklein123 requested changes Jun 7, 2022

View reviewed changes

api/envoy/admin/v3/listeners.proto Outdated Show resolved Hide resolved

repokitteh-read-only bot added the waiting label Jun 7, 2022

ggreenway reviewed Jun 7, 2022

View reviewed changes

address comments

7a2bf3b

Signed-off-by: He Jie Xu <hejie.xu@intel.com>

repokitteh-read-only bot removed the waiting label Jun 8, 2022

mattklein123 previously approved these changes Jun 8, 2022

View reviewed changes

repokitteh-read-only bot removed the api label Jun 8, 2022

mattklein123 assigned ggreenway and unassigned adisuissa and mattklein123 Jun 8, 2022

ggreenway requested changes Jun 8, 2022

View reviewed changes

api/envoy/config/listener/v3/listener.proto Outdated Show resolved Hide resolved

repokitteh-read-only bot added the waiting label Jun 8, 2022

remove repeated

542c094

Signed-off-by: He Jie Xu <hejie.xu@intel.com>

soulxu dismissed mattklein123’s stale review via 542c094 June 8, 2022 22:56

repokitteh-read-only bot added api and removed waiting labels Jun 8, 2022

ggreenway approved these changes Jun 8, 2022

View reviewed changes

mattklein123 approved these changes Jun 9, 2022

View reviewed changes

repokitteh-read-only bot removed the api label Jun 9, 2022

mattklein123 merged commit 10533dd into envoyproxy:main Jun 9, 2022

tyxia pushed a commit to tyxia/envoy that referenced this pull request Jun 14, 2022

Listener: the API change for multiple addresses support (envoyproxy#2…

8ad1e39

…1391) Signed-off-by: He Jie Xu <hejie.xu@intel.com> Signed-off-by: Tianyu Xia <tyxia@google.com>

Amila-Rukshan pushed a commit to Amila-Rukshan/envoy that referenced this pull request Jun 28, 2022

Listener: the API change for multiple addresses support (envoyproxy#2…

e9ec37a

…1391) Signed-off-by: He Jie Xu <hejie.xu@intel.com> Signed-off-by: Amila Senadheera <amila.15@cse.mrt.ac.lk>

zhlsunshine mentioned this pull request Oct 25, 2022

Support Dual Stack in Istio based on optimized design solution istio/istio#40394

Open

Conversation

soulxu commented May 20, 2022

Uh oh!

repokitteh-read-only bot commented May 20, 2022

Uh oh!

soulxu commented May 20, 2022

Uh oh!

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

soulxu commented May 27, 2022

Uh oh!

repokitteh-read-only bot commented May 27, 2022

Uh oh!

soulxu commented May 27, 2022

Uh oh!

soulxu commented Jun 2, 2022

Uh oh!

repokitteh-read-only bot commented Jun 2, 2022

Uh oh!

soulxu commented Jun 2, 2022

Uh oh!

repokitteh-read-only bot commented Jun 2, 2022

Uh oh!

soulxu commented Jun 2, 2022

Uh oh!

soulxu commented Jun 6, 2022

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ggreenway left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mattklein123 commented Jun 7, 2022

Uh oh!

soulxu commented Jun 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

soulxu commented Jun 8, 2022

Uh oh!

repokitteh-read-only bot commented Jun 8, 2022

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

ggreenway left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

soulxu commented Jun 9, 2022

Uh oh!

repokitteh-read-only bot commented Jun 9, 2022

Uh oh!

soulxu commented Jun 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ggreenway left a comment •

edited

Loading

soulxu commented Jun 8, 2022 •

edited

Loading

soulxu commented Jun 9, 2022 •

edited

Loading