v2 api: RL, Client SSL, and other filters#2132
Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom Nov 30, 2017
Merged
v2 api: RL, Client SSL, and other filters#2132mattklein123 merged 4 commits intoenvoyproxy:masterfrom
mattklein123 merged 4 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Shriram Rajagopalan <shriram@us.ibm.com>
htuch
reviewed
Nov 30, 2017
source/common/config/filter_json.cc
Outdated
| auto* descriptors = proto_config.mutable_descriptors(); | ||
| for (const auto& json_descriptor : json_config.getObjectArray("descriptors", false)) { | ||
| auto* descriptor = descriptors->Add(); | ||
| auto* entries = descriptor->mutable_entries(); |
Member
There was a problem hiding this comment.
Nit: I would just collapse the above two lines.
source/common/config/filter_json.cc
Outdated
| entry->set_address_prefix(cidr_str.substr(0, split_index)); | ||
| if (split_index != std::string::npos) { | ||
| const char* prefix_len_str = cidr_str.substr(split_index + 1, std::string::npos).c_str(); | ||
| entry->mutable_prefix_len()->set_value(std::atoi(prefix_len_str)); |
Member
There was a problem hiding this comment.
There is already CIDR stuff here: https://github.com/envoyproxy/envoy/blob/master/source/common/config/address_json.h#L32
added 2 commits
November 30, 2017 13:38
Signed-off-by: Shriram Rajagopalan <shriram@us.ibm.com>
Member
|
@rshriram please fix format |
Signed-off-by: Shriram Rajagopalan <shriram@us.ibm.com>
mattklein123
approved these changes
Nov 30, 2017
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Awesome, thanks! Go team!
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shriram Rajagopalan shriram@us.ibm.com
title: Moving rate limit (http/tcp), client ssl auth, echo filters to v2
Description: Filter conversion, some test case cleanup, code cleanup to have uniform variable naming, etc. Also removed deprecated_v1 from integration tests..
Risk Level: Medium
Testing: Unit tests and integration tests