Skip to content

docs: Clarify that RegexMatcher uses a full regex match #20570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggreenway merged 2 commits into from
Mar 30, 2022
Merged

docs: Clarify that RegexMatcher uses a full regex match #20570

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de0dc3f
docs: Clarify that RegexMatcher uses a full regex match
ggreenway Mar 29, 2022
a12dca7
update wording
ggreenway Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion api/envoy/type/matcher/v3/regex.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ message RegexMatcher {
GoogleRE2 google_re2 = 1 [(validate.rules).message = {required: true}];
}

// The regex match string. The string must be supported by the configured engine.
// The regex match string. The string must be supported by the configured engine. The regex should

@ggreenway ggreenway Mar 29, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not thrilled with this wording. Anyone have a better way to phrase it?

@daixiang0 daixiang0 Mar 30, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The full match string supported by the specified regex engine?

@markdroth markdroth Mar 30, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "The regex is matched against the full string, not as a partial match."

// specify a full input match, not a partial match.
string regex = 2 [(validate.rules).string = {min_len: 1}];
}

Expand Down