Skip to content

json: remove envoy.reloadable_features.remove_legacy_json and legacy code paths#20282

Merged
yanavlasov merged 4 commits intoenvoyproxy:mainfrom
yanavlasov:decommission-rapidjson
Mar 10, 2022
Merged

json: remove envoy.reloadable_features.remove_legacy_json and legacy code paths#20282
yanavlasov merged 4 commits intoenvoyproxy:mainfrom
yanavlasov:decommission-rapidjson

Conversation

@yanavlasov
Copy link
Copy Markdown
Contributor

@yanavlasov yanavlasov commented Mar 10, 2022

Commit Message:
json: removed envoy.reloadable_features.remove_legacy_json and legacy code paths
Risk Level: Low
Testing: Unit Tests
Docs Changes: N/A
Release Notes: Yes
Platform Specific Features: No

Signed-off-by: Yan Avlasov yavlasov@google.com

…flag

Signed-off-by: Yan Avlasov <yavlasov@google.com>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Mar 10, 2022
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123

🐱

Caused by: #20282 was opened by yanavlasov.

see: more, trace.

@daixiang0
Copy link
Copy Markdown
Member

Could you share more details about this change?

@moderation
Copy link
Copy Markdown
Contributor

Prior attempt by @keith at #19826

Signed-off-by: Yan Avlasov <yavlasov@google.com>
Signed-off-by: Yan Avlasov <yavlasov@google.com>
@yanavlasov yanavlasov changed the title Decommission rapidjson use in Envoy and delete corresponding runtime flag json: remove envoy.reloadable_features.remove_legacy_json and legacy code paths Mar 10, 2022
@yanavlasov
Copy link
Copy Markdown
Contributor Author

This PR removes use of rapidjson from Envoy source code. It is still used in the zipkin tracer external dependency.

Signed-off-by: Yan Avlasov <yavlasov@google.com>
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Mar 10, 2022
@yanavlasov yanavlasov enabled auto-merge (squash) March 10, 2022 16:16
@yanavlasov yanavlasov merged commit d596cb5 into envoyproxy:main Mar 10, 2022
@yanavlasov yanavlasov deleted the decommission-rapidjson branch March 10, 2022 18:13
JuniorHsu pushed a commit to JuniorHsu/envoy that referenced this pull request Mar 17, 2022
…acy code paths (envoyproxy#20282)

Signed-off-by: Yan Avlasov <yavlasov@google.com>
Signed-off-by: kuochunghsu <kuochunghsu@pinterest.com>
ravenblackx pushed a commit to ravenblackx/envoy that referenced this pull request Jun 8, 2022
…acy code paths (envoyproxy#20282)

Signed-off-by: Yan Avlasov <yavlasov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants