Conversation
|
This might be too early, but I wanted to see what the impact of this change would be |
This has been replaced by nlohmann/json envoyproxy#4705 Unfortunately this library cannot be removed entirely because it is used by opencensus-cpp. We continue to load it here because upstream they do not pin the dependency to a specific version, which could lead to random failures as that library is updated upstream. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
keith
force-pushed
the
ks/remove-rapidjson-direct-dependency
branch
from
edb394f to
92b833e
Compare
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
|
Related issue: #9958 OpenCensus is deprecated - can we just remove this extension enabling the path to remove RapidJSON? |
|
Oh good to know! Based on https://github.com/census-instrumentation/opencensus-cpp/search?q=rapidjson I think I would have to remove zipkin entirely, is that something that could be done now or does that need to wait for that issue? |
|
Zipkin is its own tracer extension and I don't believe removing the OpenCensus extension will impact that https://github.com/envoyproxy/envoy/tree/main/source/extensions/tracers |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
github-actions
bot
added
the
stale
3 participants
This has been replaced by nlohmann/json
#4705
Unfortunately this library cannot be removed entirely because it is used
by opencensus-cpp. We continue to load it here because upstream they do
not pin the dependency to a specific version, which could lead to random
failures as that library is updated upstream.
Signed-off-by: Keith Smiley keithbsmiley@gmail.com