Skip to content

log: log each http filter config in single line #20258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zuercher merged 1 commit into from
Mar 10, 2022
Merged

log: log each http filter config in single line #20258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/extensions/filters/network/dubbo_proxy/config.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ void ConfigImpl::registerFilter(const DubboFilterConfig& proto_config) {
ENVOY_LOG(debug, " dubbo filter #{}", filter_factories_.size());
ENVOY_LOG(debug, " name: {}", string_name);
ENVOY_LOG(debug, " config: {}",
MessageUtil::getJsonStringFromMessageOrError(proto_config.config(), true));
MessageUtil::getJsonStringFromMessageOrError(proto_config.config()));

auto& factory =
Envoy::Config::Utility::getAndCheckFactoryByName<DubboFilters::NamedDubboFilterConfigFactory>(
Expand Down
2 changes: 1 addition & 1 deletion source/extensions/filters/network/http_connection_manager/config.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,7 @@ void HttpConnectionManagerConfig::processFilter(
ENVOY_LOG(debug, " name: {}", filter_config_provider->name());
ENVOY_LOG(debug, " config: {}",
MessageUtil::getJsonStringFromMessageOrError(
static_cast<const Protobuf::Message&>(proto_config.typed_config()), true));
static_cast<const Protobuf::Message&>(proto_config.typed_config())));
filter_factories.push_back(std::move(filter_config_provider));
}

Expand Down
2 changes: 1 addition & 1 deletion test/common/upstream/subset_lb_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2458,7 +2458,7 @@ TEST_F(SubsetLoadBalancerSingleHostPerSubsetTest, DuplicateMetadataStat) {
// The first 'a' is the original, the next 2 instances of 'a' are duplicates (counted
// in stat), and 'b' is another non-duplicate.
for (auto& gauge : stats_store_.gauges()) {
ENVOY_LOG_MISC(error, "name {} value {}", gauge->name(), gauge->value());
ENVOY_LOG_MISC(debug, "name {} value {}", gauge->name(), gauge->value());
}
EXPECT_EQ(2, TestUtility::findGauge(stats_store_,
"testprefix.lb_subsets_single_host_per_subset_duplicate")
Expand Down
2 changes: 1 addition & 1 deletion test/extensions/filters/listener/tls_inspector/tls_inspector_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class TlsInspectorTest : public testing::TestWithParam<std::tuple<uint16_t, uint
EXPECT_CALL(os_sys_calls_, recv(42, _, _, MSG_PEEK))
.WillOnce(
Invoke([](os_fd_t fd, void* buffer, size_t length, int flag) -> Api::SysCallSizeResult {
ENVOY_LOG_MISC(error, "In mock syscall recv {} {} {} {}", fd, buffer, length, flag);
ENVOY_LOG_MISC(debug, "In mock syscall recv {} {} {} {}", fd, buffer, length, flag);
return Api::SysCallSizeResult{ssize_t(-1), SOCKET_ERROR_AGAIN};
}));
EXPECT_CALL(dispatcher_, createFileEvent_(_, _, Event::PlatformDefaultTriggerType,
Expand Down
2 changes: 1 addition & 1 deletion test/integration/extension_discovery_integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ class ExtensionDiscoveryIntegrationTest : public Grpc::GrpcClientIntegrationPara
config_helper_.addConfigModifier([this](envoy::config::bootstrap::v3::Bootstrap& bootstrap) {
listener_config_.Swap(bootstrap.mutable_static_resources()->mutable_listeners(0));
listener_config_.set_name(listener_name_);
ENVOY_LOG_MISC(error, "listener config: {}", listener_config_.DebugString());
ENVOY_LOG_MISC(debug, "listener config: {}", listener_config_.DebugString());
bootstrap.mutable_static_resources()->mutable_listeners()->Clear();
auto* lds_config_source = bootstrap.mutable_dynamic_resources()->mutable_lds_config();
lds_config_source->set_resource_api_version(envoy::config::core::v3::ApiVersion::V3);
Expand Down
2 changes: 1 addition & 1 deletion test/integration/listener_lds_integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ class ListenerIntegrationTest : public HttpIntegrationTest,
config_helper_.addConfigModifier([this](envoy::config::bootstrap::v3::Bootstrap& bootstrap) {
listener_config_.Swap(bootstrap.mutable_static_resources()->mutable_listeners(0));
listener_config_.set_name(listener_name_);
ENVOY_LOG_MISC(error, "listener config: {}", listener_config_.DebugString());
ENVOY_LOG_MISC(debug, "listener config: {}", listener_config_.DebugString());
bootstrap.mutable_static_resources()->mutable_listeners()->Clear();
auto* lds_config_source = bootstrap.mutable_dynamic_resources()->mutable_lds_config();
lds_config_source->set_resource_api_version(envoy::config::core::v3::ApiVersion::V3);
Expand Down