log: log each http filter config in single line#20258
Merged
zuercher merged 1 commit intoenvoyproxy:mainfrom Mar 10, 2022
Merged
log: log each http filter config in single line#20258zuercher merged 1 commit intoenvoyproxy:mainfrom
zuercher merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
lambdai
requested review from
KBaichoo,
alyssawilk,
ggreenway,
lizan and
mattklein123
as code owners
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
|
/assign @zuercher |
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
The multi line json config is annoying because it doesn't contain timestamp and occupy a large screen space. Note that this log behavior in HCM aligns was done in network filter at listener and cluster. Also degrade some obvious non-error logs. Risk Level: LOW Testing: n/a Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Yuchen Dai <silentdai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
The multi line json config is annoying because it doesn't contain timestamp and occupy a large screen space.
Note that this log behavior in HCM aligns was done in network filter at listener and cluster.
Signed-off-by: Yuchen Dai silentdai@gmail.com
Additional Description:
Also degrade some obvious non-error logs.
Risk Level: LOW
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]