Fix CI for release/v1.18#20223
Conversation
examples: Fix flask import (envoyproxy#20038) * examples: Fix flask import Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: phlax <phlax@users.noreply.github.com> Signed-off-by: Ryan Hamilton rch@google.com
build(deps): bump github/codeql-action from 1.1.2 to 1.1.3 (envoyproxy#20107) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1.1.2 to 1.1.3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@d39d5d5...75f07e7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Ryan Hamilton <rch@google.com> Signed-off-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Lizan Zhou <lizan@tetrate.io> Signed-off-by: Ryan Hamilton <rch@google.com>
Signed-off-by: Ryan Hamilton <rch@google.com>
Signed-off-by: Ryan Hamilton <rch@google.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com> Signed-off-by: Ryan Hamilton <rch@google.com>
|
The mac CI failure isn't one I've seen before. Is this a gURL issue? |
|
Yeah, the mac error is #20245 |
|
That's fine with me; you'll need to get a repo-admin to merge it past the CI failure |
|
@mattklein123 Would you care to force merge this to move the CI ball forward? I filed #20360 to track the underlying failure. |
daixiang0
left a comment
There was a problem hiding this comment.
Pin commit looks good to me.
|
@RyanTheOptimist here is a diff which diff --git a/examples/cache/docker-compose.yaml b/examples/cache/docker-compose.yaml
index 058cf203b3..98619eba73 100644
--- a/examples/cache/docker-compose.yaml
+++ b/examples/cache/docker-compose.yaml
@@ -5,8 +5,6 @@ services:
build:
context: .
dockerfile: Dockerfile-frontenvoy
- networks:
- - envoymesh
ports:
- "8000:8000"
@@ -16,8 +14,6 @@ services:
dockerfile: Dockerfile-service
volumes:
- ./responses.yaml:/etc/responses.yaml
- networks:
- - envoymesh
environment:
- SERVICE_NAME=1
@@ -27,10 +23,5 @@ services:
dockerfile: Dockerfile-service
volumes:
- ./responses.yaml:/etc/responses.yaml
- networks:
- - envoymesh
environment:
- SERVICE_NAME=2
-
-networks:
- envoymesh: {} |
|
hmm - actually that didnt fix - i think what i was addressing was more symptom than cause i think the real issue is as described in #20366 i will raise PRs on each of the active branches to address this issue, and hopefully prevent future breakages moving forward, i dont see any way around this than manually setting these n the release branches (after the branch has released) |
Backport: examples: Fix flask import (#20038)
Signed-off-by: Ryan Northey ryan@synca.io
Signed-off-by: phlax phlax@users.noreply.github.com
Backport: build(deps): bump github/codeql-action from 1.1.2 to 1.1.3 (#20107)
Bumps github/codeql-action from 1.1.2 to 1.1.3.
updated-dependencies:
dependency-type: direct:production
update-type: version-update:semver-patch
Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Ryan Hamilton rch@google.com
Backport: ci: not using alpine image in examples (#19805)
Signed-off-by: Lizan Zhou lizan@tetrate.io
Signed-off-by: Ryan Hamilton rch@google.com