Merged
Conversation
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
All Wasm tests now take both: runtime and language as parameters, which allows us to filter available inputs in a single location. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Contributor
Author
|
Stacked on #19615. |
rojkov
reviewed
Jan 21, 2022
Member
rojkov
left a comment
rojkov
left a comment
There was a problem hiding this comment.
This looks much cleaner! I added one nit.
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
rojkov
approved these changes
Jan 24, 2022
Member
rojkov
left a comment
rojkov
left a comment
There was a problem hiding this comment.
Looks very good to me. Thanks!
/assign-from @envoyproxy/senior-maintainers
|
@envoyproxy/senior-maintainers assignee is @zuercher |
Contributor
Author
|
Note: this should be merged after #19615 (which is already approved). |
zuercher
approved these changes
Jan 24, 2022
…_matrix Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
Author
|
#19615 has been merged, so this is good to go. Thanks! |
joshperry
pushed a commit
to joshperry/envoy
that referenced
this pull request
Feb 13, 2022
All Wasm tests now take both: runtime and language as parameters, which allows us to filter available inputs in a single location. Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Josh Perry <josh.perry@mx.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Wasm tests now take both: runtime and language as parameters,
which allows us to filter available inputs in a single location.
Signed-off-by: Piotr Sikora piotrsikora@google.com