wasm: exclude C++ tests on all unsupported platforms.#19615
Merged
lizan merged 2 commits intoenvoyproxy:mainfrom Jan 24, 2022
Merged
wasm: exclude C++ tests on all unsupported platforms.#19615lizan merged 2 commits intoenvoyproxy:mainfrom
lizan merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
lizan
reviewed
Jan 20, 2022
| TEST_P(WasmAccessLogConfigTest, CreateWasmFromWASM) { | ||
| #if defined(__aarch64__) | ||
| // TODO(PiotrSikora): There are no Emscripten releases for arm64. | ||
| #if !defined(__x86_64__) |
Member
There was a problem hiding this comment.
Can we define our own macros in bazel rules (like ENVOY_WASM_ENABLE_CPP_TESTS) for these? So when we change how these are enabled we don't need to change all of the tests.
Contributor
Author
There was a problem hiding this comment.
I did something similar (#19641), but it's quite a big refactor of tests and the core change here is completely lost in the refactoring, so I'd prefer if we could merge this as-is for the fixed #define, and then get the refactored tests merged.
PiotrSikora
added a commit
to PiotrSikora/envoy
that referenced
this pull request
Jan 20, 2022
Extracted into a separate PR: envoyproxy#19615. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
lizan
approved these changes
Jan 24, 2022
joshperry
pushed a commit
to joshperry/envoy
that referenced
this pull request
Feb 13, 2022
Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Josh Perry <josh.perry@mx.com>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Nov 16, 2022
Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
that referenced
this pull request
Nov 18, 2022
Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Piotr Sikora piotrsikora@google.com