transport sockets: support passthrough state for internal connections by kyessenov · Pull Request #19435 · envoyproxy/envoy

kyessenov · 2022-01-06T23:20:31Z

Signed-off-by: Kuat Yessenov kuat@google.com

Implements a special transport socket for transferring state (metadata and filter state) over the internal connection.
This transport socket captures a subset of endpoint metadata, cluster metadata, and stream filter state in the user space socket. When an internal listener accepts a user space socket connection, it immediately merges this passthrough state into the connection stream info. Because the state can be transferred from HTTP stream to TCP stream, this transport socket also participates in the hashing decisions in the HTTP connection pools.

Commit Message: Add passhtrough state over internal connection.
Risk Level: low, new extension
Testing: WIP
Docs Changes: yes
Release Notes: yes
Platform Specific Features:
Fixes: #19274

Signed-off-by: Kuat Yessenov <kuat@google.com>

repokitteh-read-only · 2022-01-06T23:20:38Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @adisuissa
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #19435 was opened by kyessenov.

see: more, trace.

Signed-off-by: Kuat Yessenov <kuat@google.com>

lambdai · 2022-01-07T17:41:41Z

@kyessenov Should we add the target internal listener address as the first field of this transport socket?

kyessenov · 2022-01-07T18:04:56Z

@lambdai I am not sure since we already have that as lb_endpoint address. I think having physical lb_endpoint address differ from the internal address in transport socket might be confusing.

kyessenov · 2022-01-10T18:41:26Z

CC @alyssawilk in case you are interested. This is bare minimum needed to propagate policies from the first upstream to the internal listener. but also could be used to propagate the actual destination.

…tadata

alyssawilk · 2022-01-14T12:58:07Z

@adisuissa ping!

…tadata

adisuissa

Thanks for working on this.
I suggest maybe setting the proto as WIP, and add #not-implemented-hide, but up to you.

/lgtm api

wrowe · 2022-01-24T17:01:29Z

I suggest maybe setting the proto as WIP, and add #not-implemented-hide

@kyessenov - your thought? In any case, merge master may hopefully clear coverage?

…tadata

kyessenov · 2022-01-24T17:56:59Z

Thanks, marked as WIP. Implementation likely needs #19467 first to land.

Signed-off-by: Kuat Yessenov <kuat@google.com>

CODEOWNERS

Signed-off-by: Kuat Yessenov <kuat@google.com>

kyessenov · 2022-06-16T00:52:42Z

/retest
(timeout)

repokitteh-read-only · 2022-06-16T00:52:46Z

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #19435 (comment) was created by @kyessenov.

see: more, trace.

wrowe · 2022-06-22T15:49:11Z

Build looks clean, @lizan - are your concerns addressed?

ggreenway · 2022-06-22T17:59:40Z

@kyessenov there's a merge conflict to resolve.

/wait

Signed-off-by: Kuat Yessenov <kuat@google.com>

kyessenov · 2022-06-22T18:54:27Z

Thanks, fixed the conflict.

wrowe · 2022-06-22T21:56:21Z

/retest

to determine whether this was a fluke;
[ RUN ] GrpcAccessLoggerCacheImplTest.LoggerCreationResourceAttributes
unknown file: Failure
C++ exception with description "Protobuf message (type opentelemetry.proto.collector.logs.v1.ExportLogsServiceRequest reason INVALID_ARGUMENT:(resource_logs.instrumentation_library_logs[0]) logs: Cannot find field.) has unknown fields" thrown in the test body.
test/extensions/access_loggers/open_telemetry/grpc_access_log_impl_test.cc:51: Failure
Actual function call count doesn't match EXPECT_CALL(*async_client, startRaw(_, _, _, _))...
Expected: to be called once
Actual: never called - unsatisfied and active

repokitteh-read-only · 2022-06-22T21:56:25Z

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #19435 (comment) was created by @wrowe.

see: more, trace.

kyessenov · 2022-06-22T21:56:42Z

/retest
(possible flake //test/extensions/access_loggers/open_telemetry:grpc_access_log_impl_test)

repokitteh-read-only · 2022-06-22T21:56:45Z

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #19435 (comment) was created by @kyessenov.

see: more, trace.

kyessenov · 2022-06-22T22:34:55Z

It's a new flake caused by f7a8db0.
Locally it passes reliably before that PR.

phlax · 2022-06-22T22:39:13Z

It's a new flake caused by f7a8db0.

apologies, addressing this now

kyessenov · 2022-06-23T03:40:56Z

/retest

repokitteh-read-only · 2022-06-23T03:41:00Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #19435 (comment) was created by @kyessenov.

see: more, trace.

…envoyproxy#19435) Implements a special transport socket for transferring state (metadata and filter state) over the internal connection. This transport socket captures a subset of endpoint metadata, cluster metadata, and stream filter state in the user space socket. When an internal listener accepts a user space socket connection, it immediately merges this passthrough state into the connection stream info. Because the state can be transferred from HTTP stream to TCP stream, this transport socket also participates in the hashing decisions in the HTTP connection pools. Commit Message: Add passhtrough state over internal connection. Risk Level: low, new extension Testing: WIP Docs Changes: yes Release Notes: yes Platform Specific Features: Fixes: envoyproxy#19274 Signed-off-by: Kuat Yessenov <kuat@google.com> Signed-off-by: Amila Senadheera <amila.15@cse.mrt.ac.lk>

Commit Message: Adds a new flag for filter state objects that indicates the intent to share with the upstream. Additional Description: Follow-up to #19809. There have been multiple reports of unexpected lifecycle changes for the filter state objects because they are stored in the transport socket options. This PR addresses this issue by introducing a new mark for filter state that explicitly changes the usage of filter state objects: marked objects always participate in the connection pool hashing (generalizing and simplifying transport sockets: support passthrough state for internal connections #19435); marked objects are copied by reference to the upstream info - this allows sharing state between downstream and upstream (and further down the chain, the internal listeners). Risk Level: medium, revert to the original behavior prior to #19809 Testing: yes Docs Changes: yes Release Notes: yes

internal listener: add metadata passthrough

5c04df2

Signed-off-by: Kuat Yessenov <kuat@google.com>

repokitteh-read-only bot added the api label Jan 6, 2022

repokitteh-read-only bot assigned adisuissa Jan 6, 2022

kyessenov added 2 commits January 7, 2022 01:14

fix

2d97b10

Signed-off-by: Kuat Yessenov <kuat@google.com>

fix

4b48cf8

Signed-off-by: Kuat Yessenov <kuat@google.com>

alyssawilk assigned wrowe Jan 11, 2022

Merge remote-tracking branch 'upstream/main' into internal_address_me…

cad2834

…tadata

Merge remote-tracking branch 'upstream/main' into internal_address_me…

9210c0d

…tadata

adisuissa reviewed Jan 19, 2022

View reviewed changes

repokitteh-read-only bot removed the api label Jan 19, 2022

Merge remote-tracking branch 'upstream/main' into internal_address_me…

20ef02a

…tadata

review

c179148

Signed-off-by: Kuat Yessenov <kuat@google.com>

kyessenov mentioned this pull request Jan 25, 2022

stream info: propagate downstream filter state to upstream #19668

Closed

kyessenov added 3 commits January 25, 2022 11:42

oops

de4bb84

Signed-off-by: Kuat Yessenov <kuat@google.com>

impl

2a0baae

Signed-off-by: Kuat Yessenov <kuat@google.com>

impl

28a8a95

Signed-off-by: Kuat Yessenov <kuat@google.com>

kyessenov requested a review from antoniovicente as a code owner January 26, 2022 22:43

repokitteh-read-only bot added the api label Jan 26, 2022

kyessenov commented Jan 26, 2022

View reviewed changes

CODEOWNERS Outdated Show resolved Hide resolved

fix metadata

a0eedce

Signed-off-by: Kuat Yessenov <kuat@google.com>

kyessenov changed the title ~~internal listener: add metadata passthrough~~ internal listener: add metadata passthrough (WIP) Jan 26, 2022

kyessenov added 2 commits January 26, 2022 15:14

wire server

942a0de

Signed-off-by: Kuat Yessenov <kuat@google.com>

docs broke

1901fbb

Signed-off-by: Kuat Yessenov <kuat@google.com>

kyessenov added 2 commits June 15, 2022 14:13

merge fix

1249d5e

Signed-off-by: Kuat Yessenov <kuat@google.com>

fix format

b41b932

Signed-off-by: Kuat Yessenov <kuat@google.com>

repokitteh-read-only bot removed the waiting label Jun 15, 2022

lizan previously approved these changes Jun 22, 2022

View reviewed changes

repokitteh-read-only bot added the waiting label Jun 22, 2022

merge fix

0192bbd

Signed-off-by: Kuat Yessenov <kuat@google.com>

kyessenov dismissed lizan’s stale review via 0192bbd June 22, 2022 18:54

repokitteh-read-only bot removed the waiting label Jun 22, 2022

lizan approved these changes Jun 22, 2022

View reviewed changes

lizan enabled auto-merge (squash) June 22, 2022 21:21

lizan merged commit 637a92a into envoyproxy:main Jun 23, 2022

kyessenov mentioned this pull request Jun 28, 2022

filter state: add a mark for sharing with the upstream #21700

Merged

adisuissa mentioned this pull request Feb 20, 2025

How to pass context/metadata across two Listeners in Envoy #38497

Closed

Conversation

kyessenov commented Jan 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only bot commented Jan 6, 2022

Uh oh!

lambdai commented Jan 7, 2022

Uh oh!

kyessenov commented Jan 7, 2022

Uh oh!

kyessenov commented Jan 10, 2022

Uh oh!

alyssawilk commented Jan 14, 2022

Uh oh!

adisuissa left a comment

Choose a reason for hiding this comment

Uh oh!

wrowe commented Jan 24, 2022

Uh oh!

kyessenov commented Jan 24, 2022

Uh oh!

Uh oh!

kyessenov commented Jun 16, 2022

Uh oh!

repokitteh-read-only bot commented Jun 16, 2022

Uh oh!

wrowe commented Jun 22, 2022

Uh oh!

ggreenway commented Jun 22, 2022

Uh oh!

kyessenov commented Jun 22, 2022

Uh oh!

wrowe commented Jun 22, 2022

Uh oh!

repokitteh-read-only bot commented Jun 22, 2022

Uh oh!

kyessenov commented Jun 22, 2022

Uh oh!

repokitteh-read-only bot commented Jun 22, 2022

Uh oh!

kyessenov commented Jun 22, 2022

Uh oh!

phlax commented Jun 22, 2022

Uh oh!

kyessenov commented Jun 23, 2022

Uh oh!

repokitteh-read-only bot commented Jun 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

kyessenov commented Jan 6, 2022 •

edited

Loading