bootstrap extension: internal listener#19467
Merged
yanavlasov merged 64 commits intoenvoyproxy:mainfrom Apr 2, 2022
Merged
Conversation
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
This reverts commit b94abcb. Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Contributor
Author
|
CC @kyessenov |
Contributor
Author
|
/assign @yanavlasov |
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
Author
|
@adisuissa Do you have further comment? |
yanavlasov
reviewed
Mar 16, 2022
lambdai
commented
Mar 16, 2022
Contributor
Author
lambdai
left a comment
lambdai
left a comment
There was a problem hiding this comment.
Thanks! I am moving the test case to the extension directory
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Contributor
Author
|
@yanavlasov I confirmed by removing the below
I believe that what we selectively import. All tests passed on my side. 893 tests pass. Do you have other concerns? |
adisuissa
reviewed
Mar 18, 2022
Contributor
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
Thanks for improving the doc. I think it is now easier to understand how to use this extension.
/lgtm api
Member
|
@yanavlasov @adisuissa looks like tests are passing, and feedback has been addressed - gtm ? |
phlax
reviewed
Mar 25, 2022
phlax
reviewed
Mar 25, 2022
phlax
reviewed
Mar 25, 2022
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
adisuissa
previously approved these changes
Mar 28, 2022
Contributor
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
Thanks!
API, docs and code changes LGTM.
@yanavlasov for another pass
Contributor
Author
|
Thank you @adisuissa |
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Contributor
|
/retest |
|
Retrying Azure Pipelines: |
yanavlasov
approved these changes
Apr 2, 2022
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
This avoid changing dispatcher interfaces when creating an internal connection at worker thread.
Additional Description:
Address the comment #18105 (comment)
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
Fixes #Issue:
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]