Skip to content

tcp: fix overenthusiastic bounds on the new pool (#19036)#19121

Merged
ggreenway merged 2 commits intoenvoyproxy:release/v1.20from
ggreenway:tcp-proxy-backport
Nov 30, 2021
Merged

tcp: fix overenthusiastic bounds on the new pool (#19036)#19121
ggreenway merged 2 commits intoenvoyproxy:release/v1.20from
ggreenway:tcp-proxy-backport

Conversation

@ggreenway
Copy link
Copy Markdown
Member

Risk Level: Low
Testing: new integration test
Docs Changes: made API more clear when requests count as connections :-/
Release Notes: inline
Fixes #19033

Signed-off-by: Alyssa Wilk alyssar@chromium.org
(cherry picked from commit 2bf8478)

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @lizan
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #19121 was opened by ggreenway.

see: more, trace.

Risk Level: Low
Testing: new integration test
Docs Changes: made API more clear when requests count as connections :-/
Release Notes: inline
Fixes envoyproxy#19033

Co-authored-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Greg Greenway <ggreenway@apple.com>
(cherry picked from commit 2bf8478)
@ggreenway ggreenway assigned alyssawilk and unassigned lizan Nov 29, 2021
Copy link
Copy Markdown
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ggreenway ggreenway enabled auto-merge (squash) November 29, 2021 17:20
@ggreenway
Copy link
Copy Markdown
Member Author

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #19121 (comment) was created by @ggreenway.

see: more, trace.

@ggreenway
Copy link
Copy Markdown
Member Author

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #19121 (comment) was created by @ggreenway.

see: more, trace.

@lizan
Copy link
Copy Markdown
Member

lizan commented Nov 30, 2021

/lgtm api

@ggreenway
Copy link
Copy Markdown
Member Author

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #19121 (comment) was created by @ggreenway.

see: more, trace.

@ggreenway ggreenway merged commit 9d0ef3f into envoyproxy:release/v1.20 Nov 30, 2021
aidanhahn pushed a commit to gravitee-io/envoy that referenced this pull request Jan 13, 2022
…nvoyproxy#19121)

Fixes envoyproxy#19033

Co-authored-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Greg Greenway <ggreenway@apple.com>
(cherry picked from commit 2bf8478)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants