tcp: fix overenthusiastic bounds on the new pool#19036
Merged
alyssawilk merged 7 commits intoenvoyproxy:mainfrom Nov 29, 2021
Merged
tcp: fix overenthusiastic bounds on the new pool#19036alyssawilk merged 7 commits intoenvoyproxy:mainfrom
alyssawilk merged 7 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
ggreenway
requested changes
Nov 17, 2021
|
|
||
| // The maximum number of parallel requests that Envoy will make to the | ||
| // upstream cluster. If not specified, the default is 1024. | ||
| // This limit is not applied as a connection limit for non-HTTP traffic. |
Member
There was a problem hiding this comment.
"This limit does not apply for non-HTTP traffic"?
Member
|
This should probably be backported. |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
ggreenway
previously approved these changes
Nov 18, 2021
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
ggreenway
approved these changes
Nov 18, 2021
ggreenway
pushed a commit
to ggreenway/envoy
that referenced
this pull request
Nov 29, 2021
Risk Level: Low Testing: new integration test Docs Changes: made API more clear when requests count as connections :-/ Release Notes: inline Fixes envoyproxy#19033 Co-authored-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Greg Greenway <ggreenway@apple.com> (cherry picked from commit 2bf8478)
alyssawilk
added
backport/approved
ggreenway
added a commit
that referenced
this pull request
Nov 30, 2021
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Nov 30, 2021
* main: (77 commits) Fix verify_and_print_latest_release logic (envoyproxy#19111) http2: drain only once when reached max_requests_per_connection (envoyproxy#19078) Overload: Reset H2 server stream only use codec level reset mechanism (envoyproxy#18895) Update QUICHE from c2ddf95dc to 7f2d442e3 (envoyproxy#19095) tools: Fix dependency checker release dates bug (envoyproxy#19109) cve_scan: Use `envoy.dependency.cve_scan` (envoyproxy#19047) tcp: fix overenthusiastic bounds on the new pool (envoyproxy#19036) dep: update Proxy-Wasm C++ host (2021-11-18). (envoyproxy#19074) build(deps): bump frozendict from 2.0.7 to 2.1.0 in /tools/base (envoyproxy#19080) kafka: dependency upgrades (envoyproxy#18995) build(deps): bump charset-normalizer in /tools/dependency (envoyproxy#19105) build(deps): bump slack-sdk in /.github/actions/pr_notifier (envoyproxy#19093) dep: Remove dependency - six (envoyproxy#19085) Remove requested_server_name_ field from StreamInfo (envoyproxy#19102) broken link path fix for items http_filters/grpc_json_transcoder_filter (envoyproxy#19101) quic: turn off GRO (envoyproxy#19088) Listener: Add global conn limit opt out. (envoyproxy#18876) Specify type for matching Subject Alternative Name. (envoyproxy#18628) Fix a broken example in Lua filter docs (envoyproxy#19086) Fix a small typo (envoyproxy#19058) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
aidanhahn
pushed a commit
to gravitee-io/envoy
that referenced
this pull request
Jan 13, 2022
…nvoyproxy#19121) Fixes envoyproxy#19033 Co-authored-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Greg Greenway <ggreenway@apple.com> (cherry picked from commit 2bf8478)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk Level: Low
Testing: new integration test
Docs Changes: made API more clear when requests count as connections :-/
Release Notes: inline
Fixes #19033