http: added support for %REQUESTED_SERVER_NAME% to extract SNI as a custom header (Fixes #19024)#19038
Merged
lizan merged 5 commits intoenvoyproxy:mainfrom Nov 18, 2021
Merged
Conversation
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Member
Author
|
/assign |
|
agrawroh is not allowed to assign users. |
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
Member
|
/assign-from @envoyproxy/first-pass-reviewers |
|
@envoyproxy/first-pass-reviewers assignee is @KBaichoo |
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
KBaichoo
reviewed
Nov 18, 2021
Contributor
KBaichoo
left a comment
KBaichoo
left a comment
There was a problem hiding this comment.
Thanks for the contribution! lgtm otherwise
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
lizan
approved these changes
Nov 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new command operator in the header formatter called
%REQUESTED_SERVER_NAME%which can be used to extract the SNI information from the stream and set it as a custom header.Commit Message: Added support for
%REQUESTED_SERVER_NAME%to extract the SNI as a custom header.Additional Description: Adds a new command operator called
%REQUESTED_SERVER_NAME%in the http header formatter which can be used to extract the SNI information from the stream and set it as a custom header.Risk Level: Low
Testing: Unit Tests
Docs Changes: Added description on
%REQUESTED_SERVER_NAME%in the docs.Release Notes: Added
Platform Specific Features: N/A
Signed-off-by: Rohit Agrawal rohit.agrawal@databricks.com