Skip to content

c-ares dns: add log on failure#18918

Merged
junr03 merged 1 commit intomainfrom
cares-log-on-failure
Nov 9, 2021
Merged

c-ares dns: add log on failure#18918
junr03 merged 1 commit intomainfrom
cares-log-on-failure

Conversation

@junr03
Copy link
Member

@junr03 junr03 commented Nov 5, 2021

Additional Description: it would be useful to see c-ares status when the callback is called.
Risk Level: low - debug log

Signed-off-by: Jose Nino jnino@lyft.com

Signed-off-by: Jose Nino <jnino@lyft.com>
Copy link
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@junr03
Copy link
Member Author

junr03 commented Nov 8, 2021

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18918 (comment) was created by @junr03.

see: more, trace.

@junr03 junr03 merged commit 7351734 into main Nov 9, 2021
@mattklein123 mattklein123 deleted the cares-log-on-failure branch November 9, 2021 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants