dns resolvers: add more details to debug logging#18413
Closed
Conversation
Signed-off-by: Jose Nino <jnino@lyft.com>
mattklein123
reviewed
Oct 4, 2021
| ENVOY_LOG_EVENT(debug, "cares_dns_resolution_complete", | ||
| "dns resolution for {} completed with status {}", dns_name_, | ||
| resolution_status); | ||
| ENVOY_LOG_EVENT( |
Member
There was a problem hiding this comment.
For c-ares due to how it's implemented, this is not going to show all addresses, right? Like it would only show v4 and return?
Member
Author
|
Will update this after #18464 lands |
Member
Author
|
/wait |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
github-actions
bot
added
the
stale
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jose Nino jnino@lyft.com