Skip to content

runtime: updates to alpha checks #18552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alyssawilk merged 4 commits into from
Oct 13, 2021
Merged

runtime: updates to alpha checks #18552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cc84188
WIP
alyssawilk Oct 11, 2021
1e53f5d
flags: trying again for alpha sorting
alyssawilk Oct 11, 2021
9dc8cc9
proposed fix
alyssawilk Oct 12, 2021
7b68a27
Merge branch 'main' into alpha
alyssawilk Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions source/common/runtime/runtime_features.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ uint64_t getInteger(absl::string_view feature, uint64_t default_value) {
// If issues are found that require a runtime feature to be disabled, it should be reported
// ASAP by filing a bug on github. Overriding non-buggy code is strongly discouraged to avoid the
// problem of the bugs being found after the old code path has been removed.
// clang-format off
constexpr const char* runtime_features[] = {
// Enabled
"envoy.reloadable_features.test_feature_true",
Expand Down Expand Up @@ -95,10 +96,13 @@ constexpr const char* runtime_features[] = {
"envoy.reloadable_features.wasm_cluster_name_envoy_grpc",
"envoy.reloadable_features.upstream_http2_flood_checks",
"envoy.restart_features.use_apple_api_for_dns_lookups",
// Misplaced flags: please do not add flags to this section.
"envoy.reloadable_features.header_map_correctly_coalesce_cookies",
"envoy.reloadable_features.sanitize_http_header_referer",
"envoy.reloadable_features.skip_dispatching_frames_for_closed_connection",
// End misplaced flags: please do not add flags in this section.
};
// clang-format on

// This is a section for officially sanctioned runtime features which are too
// high risk to be enabled by default. Examples where we have opted to land
Expand Down
4 changes: 2 additions & 2 deletions tools/code_format/check_format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,6 @@

UNSORTED_FLAGS = {
"envoy.reloadable_features.activate_timers_next_event_loop",
"envoy.reloadable_features.check_ocsp_policy",
"envoy.reloadable_features.grpc_json_transcoder_adhere_to_buffer_limits",
"envoy.reloadable_features.upstream_http2_flood_checks",
"envoy.reloadable_features.header_map_correctly_coalesce_cookies",
Expand Down Expand Up @@ -531,7 +530,8 @@ def check_runtime_flags(self, file_path, error_messages):
continue
if "}" in line:
break

if "//" in line:
continue
match = FLAG_REGEX.match(line)
if not match:
error_messages.append("%s does not look like a reloadable flag" % line)
Expand Down