Skip to content

[WIP] deps: Bump org_llvm_* -> 13.0.0#18521

Closed
phlax wants to merge 1 commit intoenvoyproxy:mainfrom
phlax:deps-bump-llvm
Closed

[WIP] deps: Bump org_llvm_* -> 13.0.0#18521
phlax wants to merge 1 commit intoenvoyproxy:mainfrom
phlax:deps-bump-llvm

Conversation

@phlax
Copy link
Member

@phlax phlax commented Oct 8, 2021

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: deps: Bump org_llvm_* -> 13.0.0
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Fix #18370 Fix #18371
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Ryan Northey <ryan@synca.io>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 8, 2021
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #18521 was opened by phlax.

see: more, trace.

@phlax
Copy link
Member Author

phlax commented Oct 8, 2021

Not sure if these should be kept in sync with each other, and with the llvm version in the build image - currently they are not

ill raise a PR on build tools to bump the version/s there also

@phlax phlax changed the title deps: Bump org_llvm_* -> 13.0.0 [WIP] deps: Bump org_llvm_* -> 13.0.0 Oct 8, 2021
@phlax phlax marked this pull request as draft October 8, 2021 09:24
@moderation
Copy link
Contributor

See this comment from @lizan that LLVM needs to be bunch with WAVM - #15021 (comment)

There are CI implications as well - I think we should align the LLVM deps with what we use for builds / CI which at the moment just changed to 12.0.1 - https://github.com/envoyproxy/envoy/pull/18220/files

@phlax
Copy link
Member Author

phlax commented Oct 8, 2021

yep, i opened a PR here envoyproxy/envoy-build-tools#155 which needswork

grepping the build tools repo and looking at the versions we have currently in Envoy - it seems like we have a bit of a mixture already

@github-actions
Copy link

github-actions bot commented Nov 7, 2021

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Nov 7, 2021
@phlax phlax added no stalebot Disables stalebot from closing an issue and removed stale stalebot believes this issue/PR has not been touched recently labels Nov 8, 2021
@alyssawilk alyssawilk closed this Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deps Approval required for changes to Envoy's external dependencies no stalebot Disables stalebot from closing an issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Newer release available org_llvm_releases_compiler_rt: llvmorg-13.0.0 Newer release available org_llvm_llvm: llvmorg-13.0.0

3 participants