Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
|
Can https://github.com/envoyproxy/envoy/blob/main/bazel/repository_locations.bzl#L824-L835 ( |
repokitteh-read-only
bot
added
the
deps
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
|
@moderation LLVM need to be upgraded together with WAVM. |
|
@lizan What do I need to be done if I want to use machine native tool chains? Install the clang-11, bazel/setup_clang.sh new clang11 dir and export CLANG_FORMAT=llvm-11/clang-format for sure. What else? |
repokitteh-read-only
bot
added
the
deps
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
|
@lambdai yes that's it. |
|
@htuch this is ready to go |
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
LGTM, thanks! @moderation can we do these bumps as distinct followup PRs?
| # | ||
| # This file was mostly manually assembled (with some hacky Python scripts) from | ||
| # clang+llvm-10.0.0-x86_64-linux-gnu-ubuntu-18.04.tar.xz and corresponding | ||
| # clang+llvm-11.0.0-x86_64-linux-gnu-ubuntu-16.04.tar.xz and corresponding |
There was a problem hiding this comment.
Are we going backward from 18.04 to 16.04 here?
There was a problem hiding this comment.
Either ubuntu 16.04 and 20.04 has prebuild 11.0.0 https://releases.llvm.org/download.html
Prebuild 11.0.0-ubuntu16.04 is running fine on my ubuntu 20.04 except lldb-11.
I guess we don't need lldb-11 during the build.
There was a problem hiding this comment.
Yeah that's because they don't have build for 18.04 and 16.04 would just work fine in 18.04.
There was a problem hiding this comment.
Fair enough; prefer going forward than back all things equal but not if there are complications.
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
|
The clang-tidy error can be ignored. merging this. |
4 participants
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]