deps: Bump bazel-buildtools -> 4.2.2#18401
Conversation
repokitteh-read-only
bot
added
the
deps
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
bump-bazel-buildtools
branch
from
593b97d to
45c522c
Compare
api/bazel/repository_locations.bzl
Outdated
| version = "4.2.0", | ||
| sha256 = "d49976b0b1e81146d79072f10cabe6634afcd318b1bd86b0102d5967121c43c1", | ||
| release_date = "2021-09-06", |
There was a problem hiding this comment.
Can we move to the latest 4.2.1?
https://github.com/bazelbuild/buildtools/releases/tag/4.2.1
There was a problem hiding this comment.
yep, missed that, thanks, ill update
There was a problem hiding this comment.
@moderation it turns out that this is correct the current release is 4.2.0 - not sure why but 4.2.1 is only a tag not a release
There was a problem hiding this comment.
The release tagged latest is 4.2.0 but the actual latest release is 4.2.1 - https://github.com/bazelbuild/buildtools/releases. I would bump this to 4.2.1 and be consistent with #18302
There was a problem hiding this comment.
my point is its a tag not a release - probs an oversight - but my guess is that the links are different
There was a problem hiding this comment.
actually - nm - the link works - ill update
|
You are aware 4.2.1 has been current for some time? |
|
for bazel yes, but this is buildozer/buildifier so i didnt make the connection i updated to 4.2.0 because that was the version on the ticket we are just improving the issue creator so that it will have upstream links, which will make it easier to check what is current (#18374) |
|
I believe this is fixed if you want to merge main to pass CI |
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
api/bazel/repository_locations.bzl
Outdated
| release_date = "2021-03-01", | ||
| version = "4.2.1", | ||
| sha256 = "b8b69615e8d9ade79f3612311b8d0c4dfe01017420c90eed11db15e9e7c9ff3c", | ||
| release_date = "2021-09-10", |
There was a problem hiding this comment.
As per CI failure the UTC for this release is 2021-09-11. The way I find this date is right click on tagged date text on Github, inspect the element in either Firefox or Chrome and find the datetime attribute below which is the UTC of the release. This is the date the checkers use
<relative-time datetime="2021-09-11T01:38:17Z" class="no-wrap" title="Sep 10, 2021, 6:38 PM PDT">26 days ago</relative-time>There was a problem hiding this comment.
thanks - github ui uses "ago" and localizes dates, both of which are deeply unhelpful when trying to check the dates
our new issue creator mostly resolves this, but in this case its showing the latest release so not showing the date for this tag version
phlax
force-pushed
the
bump-bazel-buildtools
branch
from
ee21105 to
7394447
Compare
phlax
force-pushed
the
bump-bazel-buildtools
branch
from
7394447 to
e76a8b1
Compare
|
@phlax good news or terrible news? |
|
ill update... |
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
changed the title
bazel-buildtools -> 4.2.0bazel-buildtools -> 4.2.2
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
4 participants
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: deps: Bump
bazel-buildtools-> 4.2.0Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Fix #18347
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]