Skip to content

build: Update bazel to 4.2.1#18302

Closed
yanavlasov wants to merge 3 commits intoenvoyproxy:mainfrom
yanavlasov:bazel4.2
Closed

build: Update bazel to 4.2.1#18302
yanavlasov wants to merge 3 commits intoenvoyproxy:mainfrom
yanavlasov:bazel4.2

Conversation

@yanavlasov
Copy link
Copy Markdown
Contributor

Signed-off-by: Yan Avlasov yavlasov@google.com

Signed-off-by: Yan Avlasov <yavlasov@google.com>
Signed-off-by: Yan Avlasov <yavlasov@google.com>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Sep 29, 2021
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #18302 was opened by yanavlasov.

see: more, trace.

Signed-off-by: Yan Avlasov <yavlasov@google.com>
@lizan lizan self-assigned this Sep 29, 2021
@wrowe
Copy link
Copy Markdown
Contributor

wrowe commented Sep 30, 2021

Confirmed that the change to bazel 4.2.1 even with clang-cl 12.0.1 still causes the following error optimizing external/com_github_grpc_grpc/_objs/grpc_lb_policy_xds_cluster_resolver/xds_cluster_resolver.obj
Appears that we have to now drop clang-cl for the time being until we get this sorted out. This is probably
closely related to clang dropping the default of -g2, and missing a unix clang flag in the corresponding
windows clang-cl compilation flags.

0x00007FF7FB9A09E0 (0x0000005D8B78D698 0x0000005D8B78D6B8 0x000002458BDEE9B0 0x00007FF7F9E7FFDA)
0x00007FF7FAB535F3 (0x000000010000000F 0x0000CF72063AA3D6 0x0000000000000000 0x000000000000000F)
0x00007FF7F9EBB562 (0x0000000000000018 0x00007FF7FB9BE2E3 0x00000000000000E8 0x000003FA000003F7)
0x00007FF7F9E8250C (0x000002458BDFBC90 0x0000005D00000000 0x0000000000000104 0x000000000000000F)
0x00007FF7F9F22A2E (0x0000000000000000 0x00007FF7FC67B2C0 0x0000000000000020 0x0000000000000004)
0x00007FF7F7C37164 (0x0000000000000005 0x000000000000003F 0x0000005D8ACED080 0x0000024500000000)
0x00007FF7F7C34344 (0x0000000000000120 0x000002458BDEE160 0x0000005D8B78E288 0x0000005D8B78E270)
0x00007FF7F9E0AAC6 (0x000002458BDEE160 0x0000005D8B78E270 0x0000005D8B78E288 0x00007FF7F96FC87B)
0x00007FF7F96FCBCF (0x0000005D8B78E2D8 0x000002458BE51320 0x000002458BE51320 0x00007FF7F96D071C)
0x00007FF7F9E0A206 (0x0000000000000000 0x0000001000000000 0x0000000000000104 0x0000000000000050)
0x00007FF7F9D042A7 (0x000002458BE10770 0x000002458BE101D0 0x000002458BE0A670 0x0000000000000026)
0x00007FF7F9D04839 (0x00007FF7F96FCEF0 0x00007FF7F9752E41 0x000002458BDBA3B0 0x00007FF7F96FCF0F)
0x00007FF7F9CEFDF6 (0x000000000000006B 0x00007FFE00000000 0x000002458BDB0000 0x0000000000000002)
0x00007FF7F7C33C35 (0x0000000000000000 0x0000000000000000 0x0000000000000000 0x0000000000000000)
0x00007FF7FB9BE9B8 (0x0000000000000000 0x0000000000000000 0x0000000000000000 0x0000000000000000)
0x00007FFE25107974 (0x0000000000000000 0x0000000000000000 0x0000000000000000 0x0000000000000000), BaseThreadInitThunk() + 0x14 bytes(s)
0x00007FFE41B5A2F1 (0x0000000000000000 0x0000000000000000 0x0000000000000000 0x0000000000000000), RtlUserThreadStart() + 0x21 bytes(s)
clang-cl: error: clang frontend command failed due to signal (use -v to see invocation)
clang version 12.0.1
Target: x86_64-pc-windows-msvc
Thread model: posix
InstalledDir: C:/Program Files/LLVM/bin
clang-cl: note: diagnostic msg: 
********************
PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
Preprocessed source(s) and associated run script(s) are located at:
clang-cl: note: diagnostic msg: C:\Windows\Temp\xds_cluster_resolver-31bafb.cpp
clang-cl: note: diagnostic msg: C:\Windows\Temp\xds_cluster_resolver-31bafb.sh
clang-cl: note: diagnostic msg: 
********************

@yanavlasov
Copy link
Copy Markdown
Contributor Author

I see. I'll have to figure out how to fix this.

@wrowe
Copy link
Copy Markdown
Contributor

wrowe commented Oct 6, 2021

clang-cl has been suspended, if you wanted to merge main to pass CI

@moderation
Copy link
Copy Markdown
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Oct 6, 2021
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 5, 2021

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Nov 5, 2021
@phlax
Copy link
Copy Markdown
Member

phlax commented Nov 8, 2021

closing this as these changes have landed already

@phlax phlax closed this Nov 8, 2021
@yanavlasov yanavlasov deleted the bazel4.2 branch February 11, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale stalebot believes this issue/PR has not been touched recently waiting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants