Skip to content

Disable sigaltstack on Apple platforms #18251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggreenway merged 2 commits into from
Sep 27, 2021
Merged

Disable sigaltstack on Apple platforms #18251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2505144
Disable sigaltstack on Apple platforms
keith Sep 24, 2021
34cd8e0
ignore
keith Sep 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions source/common/signal/signal_action.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,16 @@ void SignalAction::sigHandler(int sig, siginfo_t* info, void* context) {
}

void SignalAction::installSigHandlers() {
// sigaltstack and backtrace() are incompatible on Apple platforms
// https://reviews.llvm.org/D28265
#if !defined(__APPLE__)
stack_t stack;
stack.ss_sp = altstack_ + guard_size_; // Guard page at one end ...
stack.ss_size = altstack_size_; // ... guard page at the other
stack.ss_flags = 0;

RELEASE_ASSERT(sigaltstack(&stack, &previous_altstack_) == 0, "");
#endif

// Make sure VersionInfo::version() is initialized so we don't allocate std::string in signal
// handlers.
Expand Down
1 change: 1 addition & 0 deletions tools/spelling/spelling_dictionary.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1088,6 +1088,7 @@ setsockopt
sig
sigaction
sigactions
sigaltstack
siginfo
signalstack
siloed
Expand Down