Disable sigaltstack on Apple platforms#18251
Merged
ggreenway merged 2 commits intoenvoyproxy:mainfrom Sep 27, 2021
Merged
Conversation
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Awesome thanks for fixing. cc @rojkov who is probably our best bet for a reviewer who understands all of this. :)
According to https://reviews.llvm.org/D28265 using `sigaltstack` with `backtrace()` (which absiel uses internally to get stack trace info) is not compatible. This results in crashes in tests not printing backtraces only on macOS envoyproxy/envoy-mobile#1827 Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
keith
force-pushed
the
ks/disable-sigaltstack-on-apple-platforms
branch
from
39ab2b4 to
2505144
Compare
Member
Author
|
a 404 from brew 🤔 |
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
rojkov
approved these changes
Sep 27, 2021
Member
rojkov
left a comment
rojkov
left a comment
There was a problem hiding this comment.
Thanks for fixing! The consequence is that stack overflows become difficult to debug on Apple, but given sigaltstack has been already non-functional on the platform it's better to go this way and to get meaningful backtraces for other cases at least.
ggreenway
approved these changes
Sep 27, 2021
junr03
added a commit
that referenced
this pull request
Sep 28, 2021
Commit Message: signal action - fully disable sigaltstack on Apple Additional Description: follow up from #18251 Risk Level: low - follow up on previous PR Platform Specific Features: only affects apple platforms Signed-off-by: Jose Nino <jnino@lyft.com>
Member
Author
|
Thanks! |
soulxu
pushed a commit
to soulxu/envoy
that referenced
this pull request
Oct 16, 2021
According to https://reviews.llvm.org/D28265 using `sigaltstack` with `backtrace()` (which absiel uses internally to get stack trace info) is not compatible. This results in crashes in tests not printing backtraces only on macOS envoyproxy/envoy-mobile#1827 Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://reviews.llvm.org/D28265 using
sigaltstackwithbacktrace()(which absiel uses internally to get stack trace info) isnot compatible. Using them together results in crashes in tests not
printing backtraces only on macOS
envoyproxy/envoy-mobile#1827