Skip to content

Keep snapped stats in MetricSnapshotImpl. #18144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggreenway merged 1 commit into from
Sep 20, 2021
Merged

Keep snapped stats in MetricSnapshotImpl. #18144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 28 additions & 12 deletions source/server/server.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,16 +166,26 @@ void InstanceImpl::failHealthcheck(bool fail) {
}

MetricSnapshotImpl::MetricSnapshotImpl(Stats::Store& store, TimeSource& time_source) {
store.forEachCounter([this](std::size_t size) mutable { counters_.reserve(size); },
[this](Stats::Counter& counter) mutable {
counters_.push_back({counter.latch(), counter});
});

store.forEachGauge([this](std::size_t size) mutable { gauges_.reserve(size); },
[this](Stats::Gauge& gauge) mutable {
ASSERT(gauge.importMode() != Stats::Gauge::ImportMode::Uninitialized);
gauges_.push_back(gauge);
});
store.forEachCounter(
[this](std::size_t size) mutable {
snapped_counters_.reserve(size);
counters_.reserve(size);
},
[this](Stats::Counter& counter) mutable {
snapped_counters_.push_back(Stats::CounterSharedPtr(&counter));
counters_.push_back({counter.latch(), counter});
});

store.forEachGauge(
[this](std::size_t size) mutable {
snapped_gauges_.reserve(size);
gauges_.reserve(size);
},
[this](Stats::Gauge& gauge) mutable {
ASSERT(gauge.importMode() != Stats::Gauge::ImportMode::Uninitialized);
snapped_gauges_.push_back(Stats::GaugeSharedPtr(&gauge));
gauges_.push_back(gauge);
});

snapped_histograms_ = store.histograms();
histograms_.reserve(snapped_histograms_.size());
Expand All @@ -184,8 +194,14 @@ MetricSnapshotImpl::MetricSnapshotImpl(Stats::Store& store, TimeSource& time_sou
}

store.forEachTextReadout(
[this](std::size_t size) mutable { text_readouts_.reserve(size); },
[this](Stats::TextReadout& text_readout) { text_readouts_.push_back(text_readout); });
[this](std::size_t size) mutable {
snapped_text_readouts_.reserve(size);
text_readouts_.reserve(size);
},
[this](Stats::TextReadout& text_readout) {
snapped_text_readouts_.push_back(Stats::TextReadoutSharedPtr(&text_readout));
text_readouts_.push_back(text_readout);
});

snapshot_time_ = time_source.systemTime();
}
Expand Down